feat: Allow process_wrapper to capture exit codes instead of forwarding them #3772
+49
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexeagle
reviewed
Dec 12, 2025
| args.process_wrapper_flags.add("--touch-file", success_marker) | ||
| outputs.append(success_marker) | ||
|
|
||
| if forward_clippy_exit_code == False: |
Contributor
There was a problem hiding this comment.
simpler: would a user ever need to set one option but not the other? If there's an exit code file, then capture, otherwise forward
Contributor
Author
There was a problem hiding this comment.
I thought about it, but I'm not convinced it's the right approach. Because this is the process wrapper so it can be used for anything, I can see someone wanting to ignore non-zero exit values but not wanting to declare a file, e.g. if we 'bazel run'.
I agree that this is not a real use case right now, so I could definitely be convinced to collapse the arguments.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Draft implementation of #3771
I'll add tests once the maintainers have confirmed that this behaviour is wanted.