API - Registration Full Text Search & User Search Endpoints #960
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shaangill025
requested review from
kris-daxiom and
thorwolpert
as code owners
thorwolpert
approved these changes
Dec 23, 2025
Collaborator
thorwolpert
left a comment
thorwolpert
left a comment
There was a problem hiding this comment.
Don't worry about changing Optional -> |, we can do that when we upgrade the linters.
Thanks for adding the Postman updates, that's appreciated.
| """ | ||
| from dataclasses import dataclass | ||
| from typing import List | ||
| from typing import List, Optional |
Collaborator
There was a problem hiding this comment.
Optional isn't used anymore, pref is to use |
Collaborator
|
There's a unit test that's failing though, the CI is failing. |
Signed-off-by: Shaanjot Gill <[email protected]>
Signed-off-by: Shaanjot Gill <[email protected]>
Signed-off-by: Shaanjot Gill <[email protected]>
Signed-off-by: Shaanjot Gill <[email protected]>
Signed-off-by: Shaanjot Gill <[email protected]>
shaangill025
force-pushed
the
pr_31493
branch
from
6873066 to
57772d2
Compare
|
Collaborator
Author
As discussed, the unit tests in CI are failing due to a connection pool issue (captured in #31487). They are all passing locally. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue:
Description of changes:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the BC Registry and Digital Services BSD 3-Clause License