Review decision component #2260
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cameron-eyds
reviewed
Oct 8, 2025
Comment on lines
+35
to
+39
| isValidate.value = false | ||
| // await updateQueuedTransfer( | ||
| // reviewId.value, | ||
| // reviewDecision.value | ||
| // ) |
Collaborator
There was a problem hiding this comment.
Future state, to be done in our 'Submission' ticket?
Is this where you would validate if the current user is the assignee and/or self assign if there is no assigned user?
Contributor
Author
There was a problem hiding this comment.
- Yep, I just picked up the submission ticket.
- For validation, we now have the isReviewable flag, which handles showing/hiding the decision component.
- For submission, I think I’ll need to add one more step — self-assignment.
cameron-eyds
reviewed
Oct 8, 2025
Comment on lines
27
to
134
| <template> | ||
| <div | ||
| :class="validationErrors.general || validationErrors.declineReasonType ? 'border-error-left' : ''"> | ||
| <div :class="'font-bold text-gray-900 bg-bcGovColor-gray2 px-[1.4rem] py-[12px] rounded-t'"> | ||
| <div class="flex justify-between"> | ||
| <div class="flex"> | ||
| <UIcon name="i-mdi-stamper" class="w-6 h-6 text-blue-350" /> | ||
| <div class="ml-2">Review Decision</div> | ||
| </div> | ||
| </div> | ||
| </div> | ||
| <div class="w-full border-t bg-white pa-6"> | ||
| <div class="grid grid-cols-12 gap-4"> | ||
| <div class="col-span-3 flex"> | ||
| <span class="text-gray-700 font-bold">Review Decision</span> | ||
| </div> | ||
|
|
||
| <div class="col-span-9"> | ||
| <div class="flex gap-[10px]"> | ||
| <UButton | ||
| size="md" | ||
| color="error" | ||
| :class="[ | ||
| 'rounded-sm flex-1 h-[44px] justify-center', | ||
| reviewDecision.statusType === ReviewStatusTypes.DECLINED ? 'bg-error/10' : '' | ||
| ]" | ||
| variant="outline" | ||
| icon="i-mdi-close" | ||
| @click="updateReviewDecision(ReviewStatusTypes.DECLINED)" | ||
| > | ||
| Decline | ||
| </UButton> | ||
| <UButton | ||
| color="success" | ||
| size="md" | ||
| :class="[ | ||
| 'rounded-sm flex-1 h-[44px] justify-center text-bcGovGray-900', | ||
| reviewDecision.statusType === ReviewStatusTypes.APPROVED ? 'bg-success/10' : '' | ||
| ]" | ||
| variant="outline" | ||
| icon="i-mdi-check" | ||
| @click="updateReviewDecision(ReviewStatusTypes.APPROVED)" | ||
| > | ||
| Approve | ||
| </UButton> | ||
| </div> | ||
|
|
||
| <div v-if="validationErrors.general" class="text-red-600 text-sm mt-2"> | ||
| {{ validationErrors.general }} | ||
| </div> | ||
|
|
||
| <div v-if="showHiddenComponent" class="mt-4 rounded animate-slide-down"> | ||
|
|
||
| <div class="space-y-4"> | ||
| <div v-if="reviewDecision.statusType === ReviewStatusTypes.DECLINED"> | ||
| <USelect | ||
| v-model="reviewDecision.declineReasonType" | ||
| :items="Object.values(ReviewDecisionTypes)" | ||
| item-title="text" | ||
| item-value="value" | ||
| placeholder="Reason for decline (will be included in client email)" | ||
| size="lg" | ||
| :ui="{ | ||
| base: [ | ||
| 'border-b-[1px] w-full h-[60px] focus:shadow-none data-[state=open]:shadow-none', | ||
| 'data-[state=open]:border-blue-350', | ||
| validationErrors.declineReasonType ? 'border-error' : '' | ||
| ], | ||
| item: 'hover:text-blue-500 hover:bg-bcGovGray-100', | ||
| placeholder: validationErrors.declineReasonType ? 'text-error' : 'text-bcGovGray-700' | ||
| }" | ||
| /> | ||
| <div v-if="validationErrors.declineReasonType" class="text-red-600 text-sm mt-1"> | ||
| {{ validationErrors.declineReasonType }} | ||
| </div> | ||
| </div> | ||
|
|
||
| <div> | ||
| <UTextarea | ||
| v-model="reviewDecision.staffNote" | ||
| placeholder="Staff note (internal)" | ||
| size="lg" | ||
| :rows="4" | ||
| :maxlength="2000" | ||
| class="w-full" | ||
| :ui="{ | ||
| slots:{ | ||
| base: [ | ||
| 'border-bcGovGray-700 focus:shadow-none', | ||
| 'focus:border-blue-350 placeholder:text-bcGovGray-700' | ||
| ], | ||
| }, | ||
| base: 'border-b-1 placeholder:text-bcGovGray-700' | ||
| }" | ||
| /> | ||
| <div class="text-xs text-gray-500 mt-1 text-end"> | ||
| {{ reviewDecision.staffNote?.length }} / 2000 | ||
| </div> | ||
| </div> | ||
| </div> | ||
| </div> | ||
| </div> | ||
| </div> | ||
| </div> | ||
|
|
||
| </div> | ||
|
|
||
| </template> |
Collaborator
There was a problem hiding this comment.
Very minor but some spacing is off here!
cameron-eyds
approved these changes
Oct 8, 2025
Collaborator
cameron-eyds
left a comment
cameron-eyds
left a comment
There was a problem hiding this comment.
Looks fantastic sir, just some minor comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #: /bcgov/entity#30748
Description of changes:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the PPR license (Apache 2.0).