Skip to content

Conversation

@cameron-eyds
Copy link
Collaborator

@cameron-eyds cameron-eyds commented Dec 15, 2025

Issue #: /bcgov/entity#31535

Description of changes:

  • Updated Business Lookup for PPR Debtor name lookup
  • filter out duplicate name results and omit identifier from lookup list
  • preserve functionality for other instances of business lookup
Screenshot 2025-12-15 at 12 05 37 PM

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the PPR license (Apache 2.0).

@chenhongjing
Copy link
Collaborator

/gcbrun

@cameron-eyds
Copy link
Collaborator Author

/gcbrun

Our CI Build needs updating.

Copy link
Collaborator

@chenhongjing chenhongjing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for the screenshot!

(Will you fix the unit tests in this pr or fix them later?)

Copy link
Collaborator

@doug-lovett doug-lovett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Deja vu!. Looks good.

@cameron-eyds
Copy link
Collaborator Author

cameron-eyds commented Dec 16, 2025

LGTM. Thanks for the screenshot!

(Will you fix the unit tests in this pr or fix them later?)

There is some errors in the test build but the tests themselves are all passing.
When there is time to work through these setup errors, i will for sure. Will address the CI build as well.

Currently Assets work is somewhat on hold, for myself as least!

@cameron-eyds cameron-eyds merged commit a0640ab into bcgov:main Dec 16, 2025
6 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants