perf: prevent closure creation in Modifier
#1714
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Func<IReadOnlyList<SyntaxToken>, PrintingContext, Doc>to prevent closure formation.Array.IndexOfwith aswitchexpressionComparison<SyntaxToken>toArray,Sortto prevent delegate creation each time.I did experiment with a
Doc.Joinoverload that takes a collection, aFunc<TElement, PrintingContext, Doc>andPrintingContext, it did save 1.2MB but it is ugly as sin and awkward to use.Benchmark (Timing is inaccurate)
Before
After