Skip to content

perf: `Combine all changes #1735

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
TimothyMakkison wants to merge 45 commits into from
Closed

perf: `Combine all changes #1735

TimothyMakkison wants to merge 45 commits into from

Conversation

@TimothyMakkison
Copy link
Contributor

@TimothyMakkison TimothyMakkison commented Nov 2, 2025

Combines all the changes I've made

Method Mean Error StdDev Gen0 Gen1 Allocated
Default_CodeFormatter_Tests 78.03 ms 1.558 ms 3.793 ms 1000.0000 - 15.5 MB
Default_CodeFormatter_Complex 169.23 ms 3.212 ms 4.177 ms 2000.0000 1000.0000 25.05 MB

Previous combination #1551

Method Mean Error StdDev Gen0 Gen1 Allocated
Default_CodeFormatter_Tests 97.86 ms 1.779 ms 2.374 ms 1000.0000 - 17.82 MB
Default_CodeFormatter_Complex 216.07 ms 4.307 ms 7.543 ms 3000.0000 1000.0000 30.79 MB

@TimothyMakkison
perf: add PooledHashSet and PooledStringBuilder
c5bfffd
@TimothyMakkison
perf: use overload for Any( SyntaxTriviaList to prevent allocations
da71f31
@TimothyMakkison
perf: add ValueListBuilder to InvocationExpression
008a558
@TimothyMakkison
perf: replace ManualSkipAny with Span extensions
3c541cc
@TimothyMakkison
perf: use ValueListBuilder for BaseMethodDeclaration
e8cdc2d
@TimothyMakkison
perf: add Doc.Null check to Argument avoids Concat creation
ef40ee8
@TimothyMakkison
perf: use Stack.Peek to reduce Pop and Push churn
1221fdf
@TimothyMakkison
perf: replace ToImmutableHashSet with manual implementation
0093494
@TimothyMakkison
perf: set capacity of List in MembersForcedLine
edbb036
@TimothyMakkison
perf: use static Func to prevent unwanted closures
af5e4a9
@TimothyMakkison
perf: use ContainsAnyExceptInRange to calculate width
77d62f9
@TimothyMakkison
perf: use ValueListBuilder for PrivatePrintLeadingTrivia
71c34ae
@TimothyMakkison
perf: prevent closure creation in Modifier
4b56354
@TimothyMakkison
perf: add new Concat types for children lengths
35055d6
@TimothyMakkison
git: rebase
6937f52
@TimothyMakkison
Merge branch 'private_print_vlb' into combine_2
b4891cf 
# Conflicts:
#	Src/CSharpier.Core/CSharp/SyntaxPrinter/SyntaxNodePrinters/CompilationUnit.cs
#	Src/CSharpier.Core/CSharp/SyntaxPrinter/SyntaxNodePrinters/ExpressionStatement.cs
@TimothyMakkison
Merge branch 'trivia_list_enumerator' into combine_2
ee1c95a
@TimothyMakkison
Merge branch 'base_method_vlb' into combine_2
d73ab58
@TimothyMakkison
Merge branch 'argument_null' into combine_2
e162edd
@TimothyMakkison
Merge branch 'peek_docs_stack' into combine_2
0743897
@TimothyMakkison
Merge branch 'member_forced_cap' into combine_2
97e3f52
@TimothyMakkison
Merge branch 'static_func' into combine_2
1b6ffbf 
# Conflicts:
#	Src/CSharpier.Core/CSharp/SyntaxPrinter/SyntaxNodePrinters/BaseMethodDeclaration.cs
@TimothyMakkison
Merge branch 'printed_width_vector' into combine_2
9ec85f5
@TimothyMakkison
Merge branch 'modifier_closure' into combine_2
1f79579
@TimothyMakkison
Merge branch 'optimise_invocation' into combine_2
519b3c4
@TimothyMakkison
Merge remote-tracking branch 'origin/object_pool' into combine_2
1a72a17 
# Conflicts:
#	Src/CSharpier.Core/Utilities/ObjectHashSet.cs
#	Src/CSharpier.Core/Utilities/ObjectPool.cs
#	Src/CSharpier.Core/Utilities/PooledStringBuilder.cs
@TimothyMakkison
merge
cfc7a0c
@TimothyMakkison
scuffed merge
3b97da6
@TimothyMakkison
fix: tests and vector width
fb9cd6e
@TimothyMakkison
perf: only run PreprocessorSymbols when #if found
196050a
@TimothyMakkison TimothyMakkison mentioned this pull request Nov 2, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@TimothyMakkison