Skip to content

perf: optimise IgnoreFile using ValueTask and Span.Replace #1740

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
TimothyMakkison wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

perf: optimise IgnoreFile using ValueTask and Span.Replace #1740

TimothyMakkison wants to merge 2 commits into from

Conversation

@TimothyMakkison
Copy link
Contributor

@TimothyMakkison TimothyMakkison commented Nov 6, 2025

  • Uses ValueTask to avoid allocating a Task in synchronous paths
  • Use a stackalloc Span<char> to resize and reformat paths
  • Avoid closure allocations for Func

Saves around 5 MB, need to figure out how to benchmark this

@TimothyMakkison TimothyMakkison marked this pull request as draft November 6, 2025 23:53
@TimothyMakkison TimothyMakkison mentioned this pull request Nov 14, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@TimothyMakkison