Skip to content

perf: delay string.Replace call #1743

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
TimothyMakkison wants to merge 1 commit into
base: main
Choose a base branch
from
Open

perf: delay string.Replace call #1743

TimothyMakkison wants to merge 1 commit into from

Conversation

@TimothyMakkison
Copy link
Contributor

@TimothyMakkison TimothyMakkison commented Nov 8, 2025 •
edited
Loading

Delay calling string.Replace until after the ignore check. Saves 7.8MB when I run it on the CSharpier repo

Before

image

After

image

@TimothyMakkison TimothyMakkison force-pushed the delay_string_replace branch 2 times, most recently from 0a4b1eb to b712be3 Compare November 8, 2025 16:03
@TimothyMakkison TimothyMakkison mentioned this pull request Nov 14, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@TimothyMakkison