-
-
Notifications
You must be signed in to change notification settings - Fork 139
feat: add global run on save option #1762
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
a41e9bc to
c1d8018
Compare
5f2c76d to
4b9f259
Compare
|
Intellij has the idea of layers so implementing this as a global setting needs to be done that way instead of adding another option. I'm not sure what needs to be done but a global setting is just one that can be saved at the "my computer" layer. And then if needed the csharpier plugin code needs to make sure the more specific layer setting takes priority. VS has a separate global setting because at least for 2022 and earlier there was nothing built-in that allowed it. I haven't looked into 2026 yet to see how the new settings work but I'm hoping it is closer to vscode. |
|
Thanks for starting work on this :-) This will be super useful, because in our organization it unfortunately happens frequently enough that people open a new solution, don't have run on save enabled for it, and get frustrated by a build error in CI. The pain has gotten bad enough that our platform team is planning to build autoformatting into CI that will create an "autofix" branch to merge into the PR branch on formatting errors. If we can get the Rider plugin to reliably work in all repositories one opens, we can make this a much better experience. |
|
I gave it another shot in #1766 and it seems to work. It doesn't use layers though, just changes everything to global settings. |
I tried doing this but I couldn't find any examples - online documentation wasn't very helpful with a lot of dead links/github repos, AI's were a little better. I'm curious to know if @martindisch found anything relevant when doing #1766.
I could modify this PR to do this, I can't just have the project settings always override the global one, because the project setting defaults to
Docs here, not sure if |
|
Based on the other PR plus some work I tried today, it doesn't seem like there is any way to get settings into Another possibility would be to have a whole section called I do think this should modify RunOnSave to be a nullable boolean. That way someone can always override the global value whether it is true or false. The way VS handles it is a nullable boolean behind the scenes but a drop down with an empty option for the null value.
|
4b9f259 to
d6fd836
Compare
|
I've implemented my previous idea. I opted to add a new
|



Full disclosure, I rarely use Java, no idea if this works, not sure how to debug plugins. I'm hoping the CI has a test for this.
Edit: Looks like I need to install Java 😭
#1739