Skip to content

Conversation

@schealex
Copy link
Contributor

Pull request summary

Description:

amount was always zero because the invaderCore was not accounted for

Testing checklist:

  • Changes are backward-compatible OR version migration code is included
  • Codebase compiles with current tsconfig configuration
  • Tested changes on {choose PUBLIC/PRIVATE} server OR changes are trivial (e.g. typos)

amount was always zero because the invaderCore was not accounted for
Copy link
Collaborator

@MatthewARoy MatthewARoy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, the cores were getting cleaned up but I believe it was only when an invasion would spawn and trigger defense.

We should consider again splitting off this into a more efficient attack/move creep specializing in killing the cores, that was previously handled in the modular dismantle function.

@schealex schealex force-pushed the dev branch 2 times, most recently from 0083050 to ec52cdd Compare November 18, 2020 14:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants