Fix wildcard certs #4
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I see in another PR that you asked for it to be opened against the |
It would fail on "validate the Let's Encrypt challenge" when attempting to issue a wildcard cert (which letsencrypt only supports via the DNS challenge method). It created a record at: _acme-challenge.*.example.com rather than what letsencrypt wanted: _acme-challenge.example.com This just uses the record name returned by ['challenge_data'] rather than assuming.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It would fail on "validate the Let's Encrypt challenge" when attempting to issue a wildcard cert (which letsencrypt only supports via the DNS challenge method).
It created a record at:
_acme-challenge.*.example.comrather than what letsencrypt wanted:
_acme-challenge.example.comThis just uses the record name returned by
['challenge_data']rather than assuming.