Build successfully with clang

[thingkingland]

This is for ABC source code to build successfully by clang compiler. There are two issues.
1.

src/base/io/io.c:1470:5: error: implicit declaration of function 'unlink' is invalid in C99
[-Werror,-Wimplicit-function-declaration]
unlink( pFileTemp );
^

The solution is to include a header

#include <unistd.h>

2. There is a warning for each file

warning: unknown warning option '-Wno-unused-but-set-variable'; did you mean
'-Wno-unused-const-variable'? [-Wunknown-warning-option]

The solution is to detect clang and do not add -Wno-unused-but-set-variable for clang in Makefile

[alanminko]

Thank you for the information.  I just committed a changeset to address (1).  We will update (2) later.

…

On 10/9/2020 1:59 PM, Thingking Land wrote: This is for ABC source code to build successfully by clang compiler. There are two issues. 1. src/base/io/io.c:1470:5: error: implicit declaration of function 'unlink' is invalid in C99 [-Werror,-Wimplicit-function-declaration] unlink( pFileTemp ); ^ The solution is to include a header #include <unistd.h> 2. There is a warning for each file warning: unknown warning option '-Wno-unused-but-set-variable'; did you mean '-Wno-unused-const-variable'? [-Wunknown-warning-option] The solution is to detect clang and do not add -Wno-unused-but-set-variable for clang in Makefile ------------------------------------------------------------------------ You can view, comment on, or merge this pull request online at: #100 Commit Summary * Build successfully with clang File Changes * *M* Makefile <https://github.com/berkeley-abc/abc/pull/100/files#diff-b67911656ef5d18c4ae36cb6741b7965> (3) * *M* src/base/io/io.c <https://github.com/berkeley-abc/abc/pull/100/files#diff-9f943483fdbdd876eea91af90ca33257> (1) Patch Links: * https://github.com/berkeley-abc/abc/pull/100.patch * https://github.com/berkeley-abc/abc/pull/100.diff — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#100>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AI4DBXRM23XIRZF7RI65RODSJ52STANCNFSM4SKQ6ASQ>.