Skip to content

Add Asset title text outline #1952

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Add Asset title text outline #1952

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions sass/components/_asset-card.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,6 +44,7 @@ $asset-card-padding: 0.4rem;
font-size: 1.2rem;
background-color: var(--asset-card-title-bg-color);
color: var(--asset-card-title-color);
text-shadow: -1px 0 black, 0 1px black, 1px 0 black, 0 -1px black;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In general, colors shouldn't be used directly, define a --asset-cart-title-text-shadow-color (verbose… 🤮) in _vars.scss in its corresponding section. The reason is that this will allow to change the shadow color for light mode.

@rparrett FYI, in case you see a similar issue in other PRs.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Anyway, no need to do the change unless we agree that we want the text shadow.

}

&__description {
Expand Down