Let BorderColor::all take impl Into<Color> (#20311)

# Objective

Remove some friction when building UI by changing `BorderColor::all` to
accept any `impl Into<Color>` type.

---------

Co-authored-by: Alice Cecile <[email protected]>

Author: ickshonpe

crates/bevy_ui/src/ui_node.rs

@@ -2116,10 +2116,17 @@ impl<T: Into<Color>> From<T> for BorderColor {
 
 impl BorderColor {
     /// Border color is transparent by default.
-    pub const DEFAULT: Self = BorderColor::all(Color::NONE);
+    pub const DEFAULT: Self = BorderColor {
+        top: Color::NONE,
+        right: Color::NONE,
+        bottom: Color::NONE,
+        left: Color::NONE,
+    };
 
     /// Helper to create a `BorderColor` struct with all borders set to the given color
-    pub const fn all(color: Color) -> Self {
+    #[inline]
+    pub fn all(color: impl Into<Color>) -> Self {
+        let color = color.into();
         Self {
             top: color,
             bottom: color,

examples/animation/animation_graph.rs

@@ -301,7 +301,7 @@ fn setup_node_rects(commands: &mut Commands) {
                     justify_content: JustifyContent::Center,
                     ..default()
                 },
-                BorderColor::all(WHITE.into()),
+                BorderColor::all(WHITE),
                 Outline::new(Val::Px(1.), Val::ZERO, Color::WHITE),
             ));
 
@@ -355,7 +355,7 @@ fn setup_node_lines(commands: &mut Commands) {
                 border: UiRect::bottom(Val::Px(1.0)),
                 ..default()
             },
-            BorderColor::all(WHITE.into()),
+            BorderColor::all(WHITE),
         ));
     }
 
@@ -370,7 +370,7 @@ fn setup_node_lines(commands: &mut Commands) {
                 border: UiRect::left(Val::Px(1.0)),
                 ..default()
             },
-            BorderColor::all(WHITE.into()),
+            BorderColor::all(WHITE),
         ));
     }
 }

examples/helpers/widgets.rs

@@ -28,7 +28,12 @@ pub struct RadioButtonText;
 pub const BUTTON_BORDER: UiRect = UiRect::all(Val::Px(1.0));
 
 /// The color of the border that surrounds buttons.
-pub const BUTTON_BORDER_COLOR: BorderColor = BorderColor::all(Color::WHITE);
+pub const BUTTON_BORDER_COLOR: BorderColor = BorderColor {
+    left: Color::WHITE,
+    right: Color::WHITE,
+    top: Color::WHITE,
+    bottom: Color::WHITE,
+};
 
 /// The amount of rounding to apply to button corners.
 pub const BUTTON_BORDER_RADIUS_SIZE: Val = Val::Px(6.0);

examples/testbed/full_ui.rs

@@ -221,7 +221,7 @@ fn setup(mut commands: Commands, asset_server: Res<AssetServer>) {
                                 justify_content: JustifyContent::Center,
                                 ..default()
                             },
-                            BorderColor::all(LIME.into()),
+                            BorderColor::all(LIME),
                             BackgroundColor(Color::srgb(0.8, 0.8, 1.)),
                         ))
                         .with_children(|parent| {

examples/testbed/ui.rs

@@ -233,7 +233,7 @@ mod borders {
                             ..default()
                         },
                         BackgroundColor(MAROON.into()),
-                        BorderColor::all(RED.into()),
+                        BorderColor::all(RED),
                         Outline {
                             width: Val::Px(10.),
                             offset: Val::Px(10.),
@@ -325,7 +325,7 @@ mod box_shadow {
                             border: UiRect::all(Val::Px(2.)),
                             ..default()
                         },
-                        BorderColor::all(WHITE.into()),
+                        BorderColor::all(WHITE),
                         border_radius,
                         BackgroundColor(BLUE.into()),
                         BoxShadow::new(
@@ -423,7 +423,7 @@ mod overflow {
                                 overflow,
                                 ..default()
                             },
-                            BorderColor::all(RED.into()),
+                            BorderColor::all(RED),
                             BackgroundColor(Color::WHITE),
                         ))
                         .with_children(|parent| {
@@ -545,7 +545,7 @@ mod layout_rounding {
                                         ..Default::default()
                                     },
                                     BackgroundColor(MAROON.into()),
-                                    BorderColor::all(DARK_BLUE.into()),
+                                    BorderColor::all(DARK_BLUE),
                                 ));
                             }
                         });

examples/ui/box_shadow.rs

@@ -172,7 +172,7 @@ fn setup(
 
             (
                 node,
-                BorderColor::all(WHITE.into()),
+                BorderColor::all(WHITE),
                 radius,
                 BackgroundColor(Color::srgb(0.21, 0.21, 0.21)),
                 BoxShadow(vec![ShadowStyle {

examples/ui/button.rs

@@ -44,7 +44,7 @@ fn button_system(
                 input_focus.set(entity);
                 **text = "Press".to_string();
                 *color = PRESSED_BUTTON.into();
-                *border_color = BorderColor::all(RED.into());
+                *border_color = BorderColor::all(RED);
 
                 // The accessibility system's only update the button's state when the `Button` component is marked as changed.
                 button.set_changed();

examples/ui/directional_navigation.rs

@@ -361,7 +361,7 @@ fn highlight_focused_element(
         if input_focus.0 == Some(entity) && input_focus_visible.0 {
             // Don't change the border size / radius here,
             // as it would result in wiggling buttons when they are focused
-            *border_color = BorderColor::all(FOCUSED_BORDER.into());
+            *border_color = BorderColor::all(FOCUSED_BORDER);
         } else {
             *border_color = BorderColor::DEFAULT;
         }

examples/ui/gradients.rs

@@ -202,7 +202,7 @@ fn setup(mut commands: Commands) {
                         )]
                 )).observe(
                     |_trigger: On<Pointer<Over>>, mut border_query: Query<&mut BorderColor, With<Button>>| {
-                    *border_query.single_mut().unwrap() = BorderColor::all(RED.into());
+                    *border_query.single_mut().unwrap() = BorderColor::all(RED);
 
 
                 })

examples/ui/tab_navigation.rs

@@ -34,7 +34,7 @@ fn button_system(
         match *interaction {
             Interaction::Pressed => {
                 *color = PRESSED_BUTTON.into();
-                *border_color = BorderColor::all(RED.into());
+                *border_color = BorderColor::all(RED);
             }
             Interaction::Hovered => {
                 *color = HOVERED_BUTTON.into();