Skip to content

Commit a8568f7

Browse files
Ensure dds enables bevy_core_pipeline/dds in bevy_anti_aliasing (#18484)
# Objective - Compile failure with `bevy_anti_aliasing` due to `dds` feature not enabling `bevy_core_pipeline/dds`, causing a public API desync. ## Solution - Ensured feature is enabled ## Testing - CI
1 parent e3968e2 commit a8568f7

File tree

2 files changed

+4
-8
lines changed

2 files changed

+4
-8
lines changed

crates/bevy_anti_aliasing/Cargo.toml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@ keywords = ["bevy"]
1212
trace = []
1313
webgl = []
1414
webgpu = []
15-
dds = ["bevy_render/dds", "bevy_image/dds"]
15+
dds = ["bevy_render/dds", "bevy_image/dds", "bevy_core_pipeline/dds"]
1616
smaa_luts = ["bevy_render/ktx2", "bevy_image/ktx2", "bevy_image/zstd"]
1717

1818
[dependencies]

crates/bevy_image/src/image.rs

Lines changed: 3 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -931,13 +931,9 @@ impl Image {
931931
#[cfg(all(debug_assertions, feature = "dds"))] name: String,
932932
buffer: &[u8],
933933
image_type: ImageType,
934-
#[expect(
935-
clippy::allow_attributes,
936-
reason = "`unused_variables` may not always lint"
937-
)]
938-
#[allow(
939-
unused_variables,
940-
reason = "`supported_compressed_formats` is needed where the image format is `Basis`, `Dds`, or `Ktx2`; if these are disabled, then `supported_compressed_formats` is unused."
934+
#[cfg_attr(
935+
not(any(feature = "basis-universal", feature = "dds", feature = "ktx2")),
936+
expect(unused_variables, reason = "only used with certain features")
941937
)]
942938
supported_compressed_formats: CompressedImageFormats,
943939
is_srgb: bool,

0 commit comments

Comments
 (0)