Commit f21114a
authored
ssr fix and add some documents (#21877)
# Objective
Screen space reflection didn't work for my program, so I tried cloning
bevy repo and running the ssr example to see whether it works or not,
and it didn't. I figured out that the problem is that
`prepare_ssr_pipelines` system only runs for views with
`ExtractedAtmosphere`. So I removed this filter because it already uses
`Has<ExtractedAtmosphere>`. And the example works afterwards.
I later found that the `With<ExtractedAtmosphere>` filter is not added
to bevy 0.17, so the problem in my own program is not the same as the
ssr example. I compared the ssr example and my program and found that I
didn't add `DefaultOpaqueRendererMethod::deferred()` resource. So I
added a few docs to state that deferred rendering is not automatically
enabled when ssr is added.
## Solution
1. remove `With<ExtractedAtmosphere>` filter in `prepare_ssr_pipelines`.
2. add more documentation.
## Testing
I tested the ssr example and atmosphere example and both look fine.1 parent afae1c0 commit f21114a
1 file changed
+2
-2
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
62 | 62 | | |
63 | 63 | | |
64 | 64 | | |
65 | | - | |
| 65 | + | |
| 66 | + | |
66 | 67 | | |
67 | 68 | | |
68 | 69 | | |
| |||
428 | 429 | | |
429 | 430 | | |
430 | 431 | | |
431 | | - | |
432 | 432 | | |
433 | 433 | | |
434 | 434 | | |
| |||
0 commit comments