- 
                Notifications
    You must be signed in to change notification settings 
- Fork 147
[MAINT] check format 'IntendedFor' fields in json files #408
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
| It would be good to implement bids-uris in some tooling before we start converting examples or even warning. | 
| 
 you mean like pybids resolving them for example? In any case fine with me. I will wrap up this PR and we can leave it hanging until we feel like using it (or not): this was not a lot of work anyway. | 
17d158f    to
    dbd281e      
    Compare
  
    === Do not change lines below ===
{
 "chain": [],
 "cmd": "python tools/update_intended_for.py",
 "exit": 0,
 "extra_inputs": [],
 "inputs": [],
 "outputs": [],
 "pwd": "."
}
^^^ Do not change lines above ^^^
    dbd281e    to
    c7673e5      
    Compare
  
    | ok added a script to maybe help us convert those URI in batches but the diff gets huge because it may alter the formatting of entire json files at times... so may need improvement... | 
| apparently this shows that the new format of URI is not supported for mircroscopy by the current version of the validator: should I open an issue on the validator at least for book keeping? | 
| 
 yes please, we should support BIDS URIs in all our validators, even the legacy one 
 agreed | 
Preferably this should be the non deprecated format: https://bids-specification.readthedocs.io/en/latest/glossary.html#objects.metadata.IntendedFor
So adding a script to check that in CI.