Skip to content

[ENH] Define channel column for events and Delimiter field for column descriptions #1483

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Nov 13, 2023
Merged

[ENH] Define channel column for events and Delimiter field for column descriptions #1483

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
a3e3d25
ENH: Define a channel column for events
effigies May 2, 2023
ab0e6a9
ENH: Define a Delimiter field for column descriptions
effigies May 2, 2023
df07a15
be clear that not the column is a list of values, but each row in tha…
sappelhoff Oct 26, 2023
8a88eaf
extend example in events spec to include delimiters
sappelhoff Oct 26, 2023
e64314b
use HED in example
sappelhoff Nov 6, 2023
d1056c1
Update src/schema/objects/columns.yaml
sappelhoff Nov 6, 2023
2a12171
Update src/modality-specific-files/task-events.md
sappelhoff Nov 13, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/schema/objects/metadata.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -574,7 +574,7 @@ Delimiter:
name: Delimiter
display_name: Delimiter
description: |
If a column may be interpreted as a list of values, the character that
If rows in a column may be interpreted as a lists of values, the character that
Copy link
Member

@VisLab VisLab Nov 11, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This might be better as:
"If a column entry may be interpreted as..."

Also, does the Delimiter only apply to "channel" column or to any column as the above implies.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Delimiter will from now on apply to any column.

separates one value from the next.
type: string
Density:
Expand Down