Skip to content

[Feat/#99] 인앱에서 로그인 시 모달 처리 #100

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
tnals0924 merged 2 commits into from
Mar 4, 2025
Merged

[Feat/#99] 인앱에서 로그인 시 모달 처리 #100

tnals0924 merged 2 commits into from
Mar 4, 2025

Conversation

@sinji2102
Copy link
Member

@sinji2102 sinji2102 commented Mar 4, 2025

📌 관련 이슈번호

🎟️ PR 유형

어떤 변경 사항이 있나요?

  • 새 기능 추가
  • 버그 수정
  • CSS 등 사용자 UI 디자인 변경
  • 리팩토링

Check List

  • 🔀 PR 제목의 형식을 잘 작성했나요?
  • 🏗️ yarn build는 성공했나요?
  • 🧹 불필요한 코드는 제거했나요? (TODO, 주석, clg... etc.)
  • ✅ 컨벤션을 지켰나요?
  • 💭 이슈는 등록했나요?
  • 🏷️ 라벨은 등록했나요?
  • 🙇‍♂️ 리뷰어를 지정했나요?

✅ Key Changes

  1. 인앱 브라우저에서 로그인 버튼 누를 시 모달 뜨도록 분기 처리
  2. 모달 내 URL 복사하기 버튼

📢 To Reviewers

  • 뭔가 되게 원시적인 방법으로... 개발해버렸어요

📸 스크린샷

@sinji2102 sinji2102 linked an issue Mar 4, 2025 that may be closed by this pull request
[ Feat ] 인스타그램/에브리타임 구글 로그인 모달 #99
Closed
1 task
@vercel
Copy link

vercel bot commented Mar 4, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
frontend ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 4, 2025 9:35am

@github-actions github-actions bot added the ✨ FEAT 기능 구현 label Mar 4, 2025
@github-actions github-actions bot requested review from daun-up and hyeonjin6530 March 4, 2025 09:35
@tnals0924 tnals0924 self-requested a review March 4, 2025 09:36
tnals0924
tnals0924 approved these changes Mar 4, 2025
View reviewed changes
Copy link
Member

@tnals0924 tnals0924 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

굿

@tnals0924 tnals0924 merged commit b6f3ee4 into develop Mar 4, 2025
4 checks passed
@sinji2102 sinji2102 deleted the feat/#99-inapp-login branch March 5, 2025 12:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tnals0924 tnals0924 tnals0924 approved these changes

@daun-up daun-up Awaiting requested review from daun-up

@hyeonjin6530 hyeonjin6530 Awaiting requested review from hyeonjin6530

Assignees

@sinji2102 sinji2102

Labels

✨ FEAT 기능 구현

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[ Feat ] 인스타그램/에브리타임 구글 로그인 모달

3 participants

@sinji2102 @tnals0924