Skip to content

Fix locale.t for Perls >= 5.10 and < 5.16 on new MacOS X 10.8 #10

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

nordicdyno
Copy link

locale.t fail in Mac OS X Mountain Lion, because buggy locales

 locale.t fail in Mac OS X Mountain Lion, because buggy locales
@nordicdyno
Copy link
Author

This patch fixes problem with perlbrew on Mountain Lion.
Perl's tests (vers < 5.16) fail on new Mac OS X.

P.S.
I tested this code heavy enough on my Macbook with M.Lion and it had worked pretty well.

@karenetheridge
Copy link

This came up today on #pr-challenge. It looks like this is still unmerged?

@bingos
Copy link
Owner

bingos commented Jan 6, 2015

https://metacpan.org/pod/Devel::PatchPerl#CAVEAT

"Devel::PatchPerl is intended only to facilitate the building of perls, not to facilitate the testing of perls. This means that it will not patch failing tests in the perl testsuite."

I possibly should have rejected it earlier.

A https://metacpan.org/pod/Devel::PatchPerl::Plugin might be a better idea for this.

@karenetheridge
Copy link

Ah interesting, a separate thing to patch tests would certainly be very useful, then! I know I've been frustrated in the past by trying to perlbrew old perls and hitting test issues that have been apparently fixed in more recent versions.

@djzort djzort mentioned this pull request Jan 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants