Skip to content

Conversation

@jean-ye
Copy link

@jean-ye jean-ye commented Feb 28, 2020

Hi! My name is Jean Ye, and I'm trying to submit this pull request for the mini project assignment!

@jean-ye
Copy link
Author

jean-ye commented Apr 30, 2020

Hi: I have some questions about the tests. I have some written already, but I'm having trouble incorporating them. When I tried the test functions in the same file, they worked. But when I tried to use them via pytest, an error message popped up. (Updated 4/30)

@leej3
Copy link

leej3 commented May 1, 2020

Woohoo! Passing tests. Congrats.

@jean-ye
Copy link
Author

jean-ye commented May 4, 2020

I'm still having weird issues using pytest in Jupyter Lab (have been committing all my new changes and relying on CircleCI to make sure I can pass my tests). I tried restarting my computer and reopening Jupyter Lab - let me know if there's anything else I should try!

@leej3
Copy link

leej3 commented May 4, 2020 via email

@leesup
Copy link

leesup commented May 11, 2020

Great job on your project! Happy to see that you used pandas to process your data. Also, congratulations on creating passing tests. I see that you created a function to move into a directory. I suggest using pathlib for this kind of work. It will make your code much cleaner. Also, instead of specifying specific numbers, try to use len() function for increased reproducibility. Again, great job on your project!

-Paul

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants