-
Notifications
You must be signed in to change notification settings - Fork 31
Jean Ye's pull request #21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
Hi: I have some questions about the tests. I have some written already, but I'm having trouble incorporating them. When I tried the test functions in the same file, they worked. But when I tried to use them via pytest, an error message popped up. (Updated 4/30) |
|
Woohoo! Passing tests. Congrats. |
|
I'm still having weird issues using pytest in Jupyter Lab (have been committing all my new changes and relying on CircleCI to make sure I can pass my tests). I tried restarting my computer and reopening Jupyter Lab - let me know if there's anything else I should try! |
|
That is unfortunate. It's not mission critical but is certainly annoying.
There are some troubleshooting tips in some of the materials for the
earlier classes. I would first just try creating a new Conda environment to
see if any funniness follows into that new context. If so then I would have
a look at ~/.bashrc and ~/.bash_profile to see if you see anything funny.
And see if the PATH variable looks correct. We can try to debug it on Thurs
if you want.
…On Sun, May 3, 2020 at 9:14 PM jean-ye ***@***.***> wrote:
I'm still having weird issues using pytest in Jupyter Lab (have been
committing all my new changes and relying on CircleCI to make sure I can
pass my tests).
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#21 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABJKZKFPFR2T3GNEVTA5ABTRPYJFZANCNFSM4K5GUYMQ>
.
|
|
Great job on your project! Happy to see that you used pandas to process your data. Also, congratulations on creating passing tests. I see that you created a function to move into a directory. I suggest using pathlib for this kind of work. It will make your code much cleaner. Also, instead of specifying specific numbers, try to use len() function for increased reproducibility. Again, great job on your project! -Paul |
Hi! My name is Jean Ye, and I'm trying to submit this pull request for the mini project assignment!