-
Notifications
You must be signed in to change notification settings - Fork 320
Modernize custom filtering #899
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers. ReviewsSee the guideline for information on the review process.
If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update. |
In `QSortFilterProxyModel`, `invalidateFilter()` is scheduled for deprecation in Qt 6.13. `beginFilterChange()` was introduced in Qt 6.9. `endFilterChange()` was introduced in Qt 6.10.
9a045b6
to
1a11cac
Compare
macOS 14.7.7 (23H723) - confirming build not broken with this change.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In
QSortFilterProxyModel::invalidateFilter()
is scheduled for deprecation in Qt 6.13. and emits warnings in Qt 6.10QSortFilterProxyModel::beginFilterChange()
was introduced in Qt 6.9.QSortFilterProxyModel::endFilterChange()
was introduced in Qt 6.10.Fixes bitcoin/bitcoin#33571.