-
Notifications
You must be signed in to change notification settings - Fork 403
chore(bdk-electrum): use new batch_transaction_get_merkle
API
#1989
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
oleonardolima
merged 1 commit into
bitcoindevkit:master
from
oleonardolima:feat/use-batch-transaction-get-merkle-api
Aug 4, 2025
Merged
chore(bdk-electrum): use new batch_transaction_get_merkle
API
#1989
oleonardolima
merged 1 commit into
bitcoindevkit:master
from
oleonardolima:feat/use-batch-transaction-get-merkle-api
Aug 4, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
819dc0c
to
befb094
Compare
2 tasks
c9899cc
to
f3d635a
Compare
3372463
to
5e2615f
Compare
ValuedMammal
reviewed
Aug 1, 2025
5e2615f
to
a464886
Compare
ValuedMammal
reviewed
Aug 2, 2025
- removes the now unused `serde_json` dependency from `bdk_electrum`. - update `batch_fetch_anchors` to use `batch_transaction_get_merkle` method instead of manually creating the batch call.
a464886
to
b663940
Compare
ValuedMammal
approved these changes
Aug 3, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ACK b663940
LagginTimes
approved these changes
Aug 4, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ACK b663940
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #1987
depends on bitcoindevkit/rust-electrum-client#170
Description
batch_fetch_anchors
to usebatch_transaction_get_merkle
method instead of manually creating the batch call.Changelog notice
Checklists
All Submissions:
cargo +nightly fmt
andcargo clippy
before committing