Skip to content

Conversation

oleonardolima
Copy link
Contributor

@oleonardolima oleonardolima commented Jul 4, 2025

fixes #1987
depends on bitcoindevkit/rust-electrum-client#170

Description

  • update batch_fetch_anchors to use batch_transaction_get_merkle method instead of manually creating the batch call.

Changelog notice

### Changes
- deps: bump `electrum-client` to 0.24.0
- Use new `batch_transaction_get_merkle` method instead of batch raw calls

Checklists

All Submissions:

  • I've signed all my commits
  • I followed the contribution guidelines
  • I ran cargo +nightly fmt and cargo clippy before committing

@oleonardolima oleonardolima self-assigned this Jul 4, 2025
@oleonardolima oleonardolima added the chore Non-coding related work label Jul 4, 2025
@oleonardolima oleonardolima force-pushed the feat/use-batch-transaction-get-merkle-api branch from 819dc0c to befb094 Compare July 4, 2025 18:51
@oleonardolima oleonardolima force-pushed the feat/use-batch-transaction-get-merkle-api branch 2 times, most recently from c9899cc to f3d635a Compare July 24, 2025 18:27
@oleonardolima oleonardolima moved this to In Progress in BDK Chain Jul 28, 2025
@oleonardolima oleonardolima added this to the Wallet 2.1.0 milestone Jul 28, 2025
@oleonardolima oleonardolima force-pushed the feat/use-batch-transaction-get-merkle-api branch 2 times, most recently from 3372463 to 5e2615f Compare August 1, 2025 12:59
@oleonardolima oleonardolima marked this pull request as ready for review August 1, 2025 13:02
@oleonardolima oleonardolima moved this from In Progress to Needs Review in BDK Chain Aug 1, 2025
@oleonardolima oleonardolima force-pushed the feat/use-batch-transaction-get-merkle-api branch from 5e2615f to a464886 Compare August 1, 2025 17:13
- removes the now unused `serde_json` dependency from `bdk_electrum`.
- update `batch_fetch_anchors` to use `batch_transaction_get_merkle`
  method instead of manually creating the batch call.
@oleonardolima oleonardolima force-pushed the feat/use-batch-transaction-get-merkle-api branch from a464886 to b663940 Compare August 2, 2025 18:08
Copy link
Collaborator

@ValuedMammal ValuedMammal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK b663940

Copy link
Contributor

@LagginTimes LagginTimes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK b663940

@oleonardolima oleonardolima merged commit a09f12a into bitcoindevkit:master Aug 4, 2025
19 checks passed
@github-project-automation github-project-automation bot moved this from Needs Review to Done in BDK Chain Aug 4, 2025
@oleonardolima oleonardolima deleted the feat/use-batch-transaction-get-merkle-api branch August 4, 2025 16:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Non-coding related work
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Implement and use batch version of transaction.get_merkle in electrum-client.
3 participants