Skip to content

fix(electrum): fix stale anchor hash on reorg #2011

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix(electrum): fix stale anchor hash on reorg #2011

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions crates/electrum/src/bdk_electrum_client.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -501,17 +501,16 @@ impl<E: ElectrumApi> BdkElectrumClient<E> {
if let Some(anchor) = anchor_cache.get(&(txid, hash)) {
results.push((txid, *anchor));
} else {
to_fetch.push((txid, height, hash));
to_fetch.push((txid, height));
}
}
}

// Fetch merkle proofs.
let txids_and_heights = to_fetch.iter().map(|&(txid, height, _)| (txid, height));
let proofs = self.inner.batch_transaction_get_merkle(txids_and_heights)?;
let proofs = self.inner.batch_transaction_get_merkle(to_fetch.iter())?;

// Validate each proof, retrying once for each stale header.
for ((txid, height, hash), proof) in to_fetch.into_iter().zip(proofs.into_iter()) {
for ((txid, height), proof) in to_fetch.into_iter().zip(proofs.into_iter()) {
let mut header = {
let cache = self.block_header_cache.lock().unwrap();
cache
Expand All @@ -536,6 +535,7 @@ impl<E: ElectrumApi> BdkElectrumClient<E> {

// Build and cache the anchor if merkle proof is valid.
if valid {
let hash = header.block_hash();
let anchor = ConfirmationBlockTime {
confirmation_time: header.time as u64,
block_id: BlockId {
Expand Down
Loading