chore(msrv): bump MSRV to `1.85.0` #2055

oleonardolima · 2025-10-02T04:44:28Z

fixes #2009

Description

It bumps the project MSRV to 1.85.0, as the latest Debian trixie release establishes that as stable, see: https://tracker.debian.org/pkg/rustc.

This PR does:

update all references to the previous 1.63.0 MSRV.
update the rust-version to 1.85.0.
update the CI to not exclude bdk_electrum anymore.
update the ci/pin-msrv.sh to 1.85.0.

Notes to the reviewers

Should we update something in the GitHub repository configuration to get rid of old mandatory CI jobs ?

Changelog notice

### Changed

- Update all references to the previous 1.63.0 MSRV.
- Update the rust-version to 1.85.0.
- Update the CI to not exclude `bdk_electrum` anymore.
- Update the ci/pin-msrv.sh to 1.85.0.

Checklists

All Submissions:

I followed the contribution guidelines

evanlinjin

ACK b6e75cb

Ran cargo test --all-features with:

❯ cargo --version
cargo 1.85.0 (d73d2caf9 2024-12-31)

.github/workflows/cont_integration.yml

oleonardolima · 2025-10-08T00:34:34Z

I've added new commits bumping the criterion version and updating the toolchain action to match the one used in bdk_wallet.

Still need to debug the CI failure now.

oleonardolima · 2025-10-08T00:41:23Z

Still need to debug the CI failure now.

~~So, IIUC we can't have no-std for bdk_electrum, because we're using both Arc and Mutex from std::sync. I'm wondering why it didn't failed before 🤔.~~

Scratch that, I didn't notice it was only in the test module.

notmandatory · 2025-10-08T01:52:47Z

cACK, will do a deeper review when I get a chance but don't wait for me if you think it's ready to go.

ValuedMammal

ACK 0f5ac52

- update all references to previous 1.63.0 MSRV. - update the rust-version to 1.85.0. - update the CI to not exclude bdk_electrum anymore. - update the ci/pin-msrv.sh to 1.85.0.

- use `is_non_or` instead of `map_or` - update lifetime on `find_direct_anchor`

oleonardolima · 2025-10-09T03:24:18Z

I had to do a rebase due to the ci/pin-msrv.sh conflict introduced by #2058.

oleonardolima · 2025-10-09T03:30:20Z

I've also updated the zizmor.yml as @ValuedMammal commented here: #2056 (comment)

ValuedMammal

ACK 81ed4d0

ValuedMammal · 2025-10-10T13:40:17Z

There's a few additional cleanups: oleonardolima/bdk@chore/bump-msrv-to-1.85.0...ValuedMammal:review_2055

ci: drop actions-rs from clippy check
ci: Remove unneeded clippy: true from build-test
ci(coverage): Switch to actions-rust-lang/setup-rust-toolchain

📌 Look into bumping rust stable version to 1.90.0

thunderbiscuit

Just a small nit: the actions-rust-lang/setup-rust-toolchain@v1 sets the config value cache to true by default, but you need to know this about the action to understand that the cache is activated if the value is not set explicitly.

In some of your steps you configure it explicitly, and that's my preferred approach. It doesn't change anything but signals to contributors that the cache is active without requiring they know in depth the action.

I would personally set the field to true on all uses of the action (or remove it entirely if you prefer the implicit way), but at the moment you set it to true on some and don't set it on others, making it less obvious why/when the cache is active.

evanlinjin · 2025-10-17T03:21:52Z

ACK changes added by @ValuedMammal here: oleonardolima/bdk@chore/bump-msrv-to-1.85.0...ValuedMammal:review_2055

Confirmed that it achieves the following:

Made cache: true consistent.
Removed unused clippy: true.
Removed deprecated clippy-check - use a simple cargo clippy command.
Drop actions-rs completely.

📌 Look into bumping rust stable version to 1.90.0

ACK on this idea. 1.90.0 will probably make our CI faster as well.

evanlinjin

self-ACK fdafe86

I cherry-picked @ValuedMammal's changes and also bumped rust-version to 1.90.

Question: Does CI changes need to appear in the changelog?

To do: Update branch protection rules before merging.

thunderbiscuit

ACK fdafe86. Looks good.

ValuedMammal · 2025-10-17T12:34:27Z

ACK fdafe86

0bd93da fix(core): Memory leak bugs in `CheckPoint::drop` impl (志宇) Pull request description: based on #1997, depends on #2055 ### Description Fix memory leak bug in CheckPoint::drop by using Arc::into_inner. Add tests (from the old PR) for memory leak + stack overflow when dropping CheckPoint. ### Notes to the reviewers It should be merged after #2055. ### Changelog notice ``` ### Fix: - Fix memory leak bug in CheckPoint::drop by using `Arc::into_inner`. ``` ### Checklists #### All Submissions: * [x] I followed the [contribution guidelines](https://github.com/bitcoindevkit/bdk/blob/master/CONTRIBUTING.md) #### Bugfixes: * [x] This pull request breaks the existing API * [x] I've added tests to reproduce the issue which are now passing * [x] I'm linking the issue being fixed by this PR ACKs for top commit: evanlinjin: ACK 0bd93da Tree-SHA512: f61bd7ee19a6eb4e0f0275882d8c7b9f0e050e868e1e7a51b4089c8c71d14478905d900c619bebe71e4ffe7117400d99e4604d6a16e3b9a7515755d3f3250c90

github-project-automation bot added this to BDK Chain Oct 2, 2025

oleonardolima force-pushed the chore/bump-msrv-to-1.85.0 branch from b04bbed to b6e75cb Compare October 2, 2025 04:53

oleonardolima marked this pull request as ready for review October 2, 2025 05:14

oleonardolima self-assigned this Oct 2, 2025

oleonardolima added chore Non-coding related work github_actions Pull requests that update GitHub Actions code labels Oct 2, 2025

oleonardolima requested review from evanlinjin and notmandatory October 2, 2025 05:14

oleonardolima moved this to Needs Review in BDK Chain Oct 2, 2025

oleonardolima modified the milestones: Wallet 3.0.0, Chain 0.24.0 Oct 2, 2025

evanlinjin approved these changes Oct 2, 2025

View reviewed changes

evanlinjin mentioned this pull request Oct 2, 2025

fix(core): Memory leak bugs in CheckPoint::drop impl #1997

Closed

2 tasks

oleonardolima mentioned this pull request Oct 2, 2025

fix(core) Checkpoint::drop memory leak #2056

Merged

4 tasks

oleonardolima force-pushed the chore/bump-msrv-to-1.85.0 branch 2 times, most recently from 8bb3255 to 93c2172 Compare October 8, 2025 00:08

github-advanced-security bot found potential problems Oct 8, 2025

View reviewed changes

oleonardolima force-pushed the chore/bump-msrv-to-1.85.0 branch 2 times, most recently from 3e626f3 to adc99e7 Compare October 8, 2025 00:22

oleonardolima force-pushed the chore/bump-msrv-to-1.85.0 branch 2 times, most recently from b4f3c30 to 0f5ac52 Compare October 8, 2025 00:48

oleonardolima requested a review from evanlinjin October 8, 2025 00:51

oleonardolima requested a review from ValuedMammal October 8, 2025 02:40

ValuedMammal mentioned this pull request Oct 8, 2025

fix(ci): update webpki-roots pinned version #2058

Merged

6 tasks

ValuedMammal approved these changes Oct 8, 2025

View reviewed changes

chore(msrv): bump MSRV to 1.85.0

8c15308

- update all references to previous 1.63.0 MSRV. - update the rust-version to 1.85.0. - update the CI to not exclude bdk_electrum anymore. - update the ci/pin-msrv.sh to 1.85.0.

oleonardolima added 2 commits October 9, 2025 14:23

fix(clippy): use is_none_or instead of map_or

6b67a34

- use `is_non_or` instead of `map_or` - update lifetime on `find_direct_anchor`

chore(deps): bump criterion to 0.7

7c189d0

oleonardolima force-pushed the chore/bump-msrv-to-1.85.0 branch from 0f5ac52 to 9af94e0 Compare October 9, 2025 03:23

feat(ci): update to actions-rust-lang/setup-rust-toolchain@v1

81ed4d0

oleonardolima force-pushed the chore/bump-msrv-to-1.85.0 branch from 9af94e0 to 81ed4d0 Compare October 9, 2025 03:29

ValuedMammal approved these changes Oct 9, 2025

View reviewed changes

thunderbiscuit reviewed Oct 10, 2025

View reviewed changes

ValuedMammal and others added 5 commits October 16, 2025 05:42

ci: drop actions-rs from clippy check

dc0c907

ci: Remove unneeded clippy: true from build-test

86df0c3

ci(coverage): Switch to actions-rust-lang/setup-rust-toolchain

eabd1be

ci: use explicit cache: true on fmt job

2f4c3d4

ci: bump rust stable version to 1.90.0 for CI testing

fdafe86

evanlinjin approved these changes Oct 17, 2025

View reviewed changes

evanlinjin requested review from ValuedMammal and thunderbiscuit October 17, 2025 03:32

evanlinjin mentioned this pull request Oct 17, 2025

Add skiplist to CheckPoint for O(√n) traversal #2048

Open

3 tasks

thunderbiscuit approved these changes Oct 17, 2025

View reviewed changes

ValuedMammal merged commit 13940d9 into bitcoindevkit:master Oct 17, 2025
17 checks passed

github-project-automation bot moved this from Needs Review to Done in BDK Chain Oct 17, 2025

oleonardolima deleted the chore/bump-msrv-to-1.85.0 branch October 17, 2025 18:06

chore(msrv): bump MSRV to 1.85.0 #2055

chore(msrv): bump MSRV to 1.85.0 #2055

Uh oh!

Conversation

oleonardolima commented Oct 2, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Notes to the reviewers

Changelog notice

Checklists

All Submissions:

Uh oh!

evanlinjin left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

oleonardolima commented Oct 8, 2025

Uh oh!

oleonardolima commented Oct 8, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

notmandatory commented Oct 8, 2025

Uh oh!

ValuedMammal left a comment

Choose a reason for hiding this comment

Uh oh!

oleonardolima commented Oct 9, 2025

Uh oh!

oleonardolima commented Oct 9, 2025

Uh oh!

ValuedMammal left a comment

Choose a reason for hiding this comment

Uh oh!

ValuedMammal commented Oct 10, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

thunderbiscuit left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

evanlinjin commented Oct 17, 2025

Uh oh!

evanlinjin left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

thunderbiscuit left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

ValuedMammal commented Oct 17, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

chore(msrv): bump MSRV to `1.85.0` #2055

chore(msrv): bump MSRV to `1.85.0` #2055

oleonardolima commented Oct 2, 2025 •

edited

Loading

evanlinjin left a comment •

edited

Loading

oleonardolima commented Oct 8, 2025 •

edited

Loading

ValuedMammal commented Oct 10, 2025 •

edited

Loading

thunderbiscuit left a comment •

edited

Loading

evanlinjin left a comment •

edited

Loading

thunderbiscuit left a comment •

edited

Loading