fix(chain): return full TxNode from CanonicalIter with debug logging #2062
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| if !self.is_canonicalized(txid) { | ||
| self.mark_canonical(txid, tx, CanonicalReason::assumed()); | ||
| } | ||
| continue; |
There was a problem hiding this comment.
You shouldn't change the behavior of the canonicalization algorithm.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request enhances the CanonicalIter in the chain module to return the full TxNode—which includes Txid, Transaction, and CanonicalReason—instead of just the Txid. This improvement allows better tracking of canonical transactions along with the reason why each transaction is considered canonical.
Additionally, debug logging has been added throughout the canonicalization process. This logging prints transaction IDs as they are processed, which makes it easier to trace the iteration flow and understand how conflicts and ancestor-descendant relationships are resolved.
These changes improve the testability and observability of canonical transaction processing in the BDK library, which is particularly useful when working with transaction graphs that have complex conflicts or multiple anchors.
Notes to Reviewers
The debug logs are temporary and intended to help during development and testing.
This change does not alter the underlying canonicalization logic but provides more detailed output and richer information per transaction.
No existing APIs are broken; only the iterator’s item type has been extended to provide more context.