[Android] Set minSdk to 23 #656
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Size Comparison Report (x86_64)
|
FranAguilera
commented
Oct 3, 2025
platform/jvm/capture/src/main/kotlin/io/bitdrift/capture/attributes/NetworkAttributes.kt
Outdated
Show resolved
Hide resolved
FranAguilera
force-pushed
the
franjam/set-back-to-min-sdk-21
branch
2 times, most recently
from
0f59b78 to
f1f368b
Compare
FranAguilera
force-pushed
the
franjam/set-back-to-min-sdk-21
branch
from
f1f368b to
28624d2
Compare
murki
reviewed
Oct 9, 2025
| updateNetworkType(connectivityManager.getNetworkCapabilities(network)) | ||
| } | ||
| connectivityManager.registerDefaultNetworkCallback(this) | ||
| if (Build.VERSION.SDK_INT < Build.VERSION_CODES.N) { |
There was a problem hiding this comment.
does this mean <23 devices will not receive networking info at all? sounds like we should fallback to the more expensive polling logic in these cases
There was a problem hiding this comment.
Oh I just reverted to what we had prior to 24 6e6eff47
There was a problem hiding this comment.
also to clarify we won't be supporting below 23
There was a problem hiding this comment.
will do more testing with various testing of network con
There was a problem hiding this comment.
verified on this session, callbacks still happening due to older API call connectivityManager.registerNetworkCallback(NetworkRequest.Builder().build(), this)
FranAguilera
force-pushed
the
franjam/set-back-to-min-sdk-21
branch
from
16479a4 to
b16ddfb
Compare
murki
approved these changes
Oct 14, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Setting minSdk to 23. This is inline with androidx minSdk level
The most relevant changes:
JankStatsMonitorto run againsendJankFrameDataoutside main thread <24NetworkAttributesto useregisterNetworkCallbackbelow <24Verification
Verified on API 23 device. Timeline session