Skip to content

ci: add ios units as steps #682

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from
Draft

ci: add ios units as steps #682

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
e45af49
ci: add ios units as steps
kattrali Oct 8, 2025
e6a947a
ci: split targets, avoid cross-build failure?
kattrali Oct 8, 2025
55d63f1
ci: replace tsan target entirely
kattrali Oct 8, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 6 additions & 5 deletions .github/workflows/ios.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,7 +78,7 @@ jobs:
# TODO(snowp): Add some kind of assertion that the app does that it's supposed to
- run: ./bazelw run --config ci --config release-ios //examples/swift/hello_world:ios_app &> /tmp/envoy.log &
name: "Run app"
macos_tsan:
ios_tests:
# Note: tsan has been disabled because it's too flaky.
# https://bitdrift.slack.com/archives/C058ZD2M2CQ/p1755792021318899?thread_ts=1755784965.888369&cid=C058ZD2M2CQ
runs-on: macos-14
Expand All @@ -91,11 +91,12 @@ jobs:

- name: "Install dependencies"
run: ./ci/mac_ci_setup.sh
- name: Run iOS tests (tsan)
run: env -u ANDROID_NDK_HOME ./bazelw test $(./bazelw query 'kind(ios_unit_test, //test/platform/swift/unit_integration/core/...)') --test_tag_filters=macos_only --test_output=errors --config ci --config ios
- name: Run iOS tests
# all test targets minus benchmarks
run: env -u ANDROID_NDK_HOME ./bazelw test $(./bazelw query 'filter(":test", kind(".*test rule", test/platform/swift/...))') --test_tag_filters=macos_only --test_output=errors --config ci --config ios
verify_ios:
runs-on: ubuntu-latest
needs: ["macos_tsan", "swift_hello_world"]
needs: ["ios_tests", "swift_hello_world"]
if: always()
steps:
# Checkout repo to Github Actions runner
Expand All @@ -104,5 +105,5 @@ jobs:
with:
fetch-depth: 1
- run: |
./ci/check_result.sh ${{ needs.macos_tsan.result }} \
./ci/check_result.sh ${{ needs.ios_tests.result }} \
&& ./ci/check_result.sh ${{ needs.swift_hello_world.result }}
Loading