[Android] Reuse OkHttpClient instance #700
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Size Comparison Report (x86_64)
|
murki
approved these changes
Oct 14, 2025
|
Let's make sure to test both connections don't mess with each other since we hack okhttp to keep a bidirectional connection open at all times (i.e. test download/uploads on both a coupe of times back and forth) |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Avoid creating 2 OkHttpClient instances
See https://square.github.io/okhttp/3.x/okhttp/okhttp3/OkHttpClient.html
Verification
Tested on gradle-test-app. See session with triggered OkHttp requests
Verify threads via profiler