Nav3 migration experiments #1494
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Arnau Mora <[email protected]>
Signed-off-by: Arnau Mora <[email protected]>
Signed-off-by: Arnau Mora <[email protected]>
Signed-off-by: Arnau Mora <[email protected]>
Signed-off-by: Arnau Mora <[email protected]>
Signed-off-by: Arnau Mora <[email protected]>
Signed-off-by: Arnau Mora <[email protected]>
Signed-off-by: Arnau Mora <[email protected]>
Signed-off-by: Arnau Mora <[email protected]>
Signed-off-by: Arnau Mora <[email protected]>
Signed-off-by: Arnau Mora <[email protected]>
|
An update has been released for AppCompat, which should fix the issue: https://developer.android.com/jetpack/androidx/releases/appcompat#1.7.1 Edit: doesn't seem to work yet |
# Conflicts: # app/src/main/kotlin/at/bitfire/davdroid/db/AppDatabase.kt # app/src/main/kotlin/at/bitfire/davdroid/ui/AccountsScreen.kt
Signed-off-by: Arnau Mora <[email protected]>
Signed-off-by: Arnau Mora <[email protected]>
|
This PR/issue depends on: |
|
As discussed, should be done for ICSx5 first |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Tried experimenting a bit with the new Navigation 3 library. Unfortunately, right now we cannot even have something to test this out, since
AppCompatActivitydoesn't seem to be supported as of right now by Nav3.Short description
Basically a lot has to change. We need:
Then, Activity Compose has to be upgraded to support Nav3 and
AppCompatActivity. See issue on Google's Tracker and on the example repository for Nav3. Basically the main issue right now is that upon starting the app crashes with:LocalNavigationEventDispatcherOwnerdoesn't even exist on the currently released version of Nav3. So we'd have to wait more.Checklist
Depends on android/nav3-recipes#6
Depends on https://issuetracker.google.com/issues/419208471