Skip to content

feat: Add Tuist archive #165

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 3 commits into
base: ACI-4001-comp-cache-benchmark
Choose a base branch
from
Draft

feat: Add Tuist archive #165

wants to merge 3 commits into from

Conversation

zsolt-marta-bitrise
Copy link
Collaborator

@zsolt-marta-bitrise zsolt-marta-bitrise commented Sep 18, 2025 •
edited
Loading

zsolt-marta-bitrise
zsolt-marta-bitrise commented Sep 18, 2025
View reviewed changes
bitrise.yml
- USE_DD_CACHE: $USE_DD_CACHE
- USE_SPM: $USE_SPM
- BENCHMARK_APP_NAME: $BENCHMARK_APP_NAME
benchmark_tuist_build_baseline:
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just reordered to be among all other tuist wfs

@bitrise-ip-bot
Copy link

bitrise-ip-bot commented Sep 18, 2025 •
edited
Loading

Summary

This PR adds Tuist archive benchmarking workflows to bitrise.yml, implementing two new workflows for baseline and compilation cache testing. The changes include new benchmark workflows with xcodebuild commands for archiving the Tuist project.

Walkthrough

File Summary
bitrise.yml Added benchmark_tuist_archive_baseline and benchmark_tuist_archive_cc workflows for Tuist archiving benchmarks

bitrise-ip-bot
bitrise-ip-bot reviewed Sep 18, 2025
View reviewed changes
Copy link

@bitrise-ip-bot bitrise-ip-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is an AI-generated review. Please review it carefully.

Actionable comments posted: 2

bitrise.yml
#!/bin/bash
set -ex
xcodebuild -workspace Tuist.xcworkspace -scheme tuist build
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🐛 Bug

Scheme mismatch will cause build failure. The new Tuist archive workflows use '-scheme tuist' but all other Tuist workflows in this file use '-scheme TuistApp'. This inconsistency will likely result in build errors since the 'tuist' scheme may not exist or may not be the correct target for the benchmark.

🔄 Suggestion:

Suggested change
xcodebuild -workspace Tuist.xcworkspace -scheme tuist build
xcodebuild -workspace Tuist.xcworkspace -scheme TuistApp build

bitrise.yml
#!/bin/bash
set -ex
xcodebuild -workspace Tuist.xcworkspace -scheme tuist build
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🐛 Bug

Scheme mismatch will cause build failure. The new Tuist archive workflows use '-scheme tuist' but all other Tuist workflows in this file use '-scheme TuistApp'. This inconsistency will likely result in build errors since the 'tuist' scheme may not exist or may not be the correct target for the benchmark.

🔄 Suggestion:

Suggested change
xcodebuild -workspace Tuist.xcworkspace -scheme tuist build
xcodebuild -workspace Tuist.xcworkspace -scheme TuistApp build

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@bitrise-ip-bot bitrise-ip-bot bitrise-ip-bot left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@zsolt-marta-bitrise @bitrise-ip-bot