Add simple x #170
Open
Add simple x #170
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SummaryThis PR adds SimpleX benchmarking workflows to the CI pipeline, including both baseline and compilation cache variants. The implementation follows existing patterns but is missing error handling in the workflow scripts. Walkthrough
|
doomsayer13
changed the base branch from
main
to
ACI-4001-comp-cache-benchmark
| title: Install dependencies | ||
| inputs: | ||
| - content: |- | ||
| ./scripts/ios/prepare-x86_64.sh |
There was a problem hiding this comment.
🐛 Bug
The script execution lacks error handling and pipefail settings that are present in other similar workflows. This could cause the build to continue even if the preparation script fails.
🔄 Suggestion:
Suggested change
| ./scripts/ios/prepare-x86_64.sh | |
| set -exo pipefail | |
| ./scripts/ios/prepare-x86_64.sh |
| title: Install dependencies | ||
| inputs: | ||
| - content: |- | ||
| ./scripts/ios/prepare-x86_64.sh |
There was a problem hiding this comment.
🐛 Bug
The script execution lacks error handling and pipefail settings that are present in other similar workflows. This could cause the build to continue even if the preparation script fails.
🔄 Suggestion:
Suggested change
| ./scripts/ios/prepare-x86_64.sh | |
| set -exo pipefail | |
| ./scripts/ios/prepare-x86_64.sh |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.