Skip to content

Conversation

patrols
Copy link

@patrols patrols commented Sep 14, 2025

Summary of changes

Relax gettext dependency constraint to allow >= 0.26.0
This allows users to choose between gettext 0.26.x and 1.0.x versions

gettext 1.0.0 changelog

Checklist

  • N/A New functions have typespecs, changed functions were updated
  • N/A Same for documentation, including moduledocs
  • N/A Tests were added or updated to cover changes
  • Commits were squashed into a single coherent commit
  • Notes added to CHANGELOG file which describe changes at a high-level

Fixes #782

@ddon
Copy link

ddon commented Sep 15, 2025

Yes, would nice, we also can't update our lib without this

mix.exs Outdated
{:tzdata, "~> 1.1"},
{:combine, "~> 0.10"},
{:gettext, "~> 0.26"},
{:gettext, "~> 1.0"},
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This forces applications to use Gettext v1.0 or higher. As there are no breaking changes and "very few changes from the latest 0.26 release", we might want to set the constraint to something like this:

Suggested change
{:gettext, "~> 1.0"},
{:gettext, ">= 0.26.0"},

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, good suggestion. Thanks 👍

This allows users to choose between gettext 0.26.x and 1.0.x versions,
maintaining backward compatibility while enabling forward compatibility.
@patrols patrols changed the title Update gettext to 1.0.0 Relax gettext dependency constraint to allow >= 0.26.0 Sep 16, 2025
@tispratik
Copy link

+1. Can we merge it?

@ddon
Copy link

ddon commented Sep 29, 2025

Would be really nice!

Copy link

@SebastianMueller87 SebastianMueller87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, can we merge it? 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Allow gettext 1.0 release

5 participants