-
Notifications
You must be signed in to change notification settings - Fork 396
Relax gettext dependency constraint to allow >= 0.26.0 #783
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Yes, would nice, we also can't update our lib without this |
mix.exs
Outdated
{:tzdata, "~> 1.1"}, | ||
{:combine, "~> 0.10"}, | ||
{:gettext, "~> 0.26"}, | ||
{:gettext, "~> 1.0"}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This forces applications to use Gettext v1.0 or higher. As there are no breaking changes and "very few changes from the latest 0.26 release", we might want to set the constraint to something like this:
{:gettext, "~> 1.0"}, | |
{:gettext, ">= 0.26.0"}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, good suggestion. Thanks 👍
This allows users to choose between gettext 0.26.x and 1.0.x versions, maintaining backward compatibility while enabling forward compatibility.
b07e063
to
aa4d7a9
Compare
+1. Can we merge it? |
Would be really nice! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, can we merge it? 😄
Summary of changes
Relax gettext dependency constraint to allow >= 0.26.0
This allows users to choose between gettext 0.26.x and 1.0.x versions
gettext 1.0.0 changelog
Checklist
Fixes #782