Relax gettext dependency constraint to allow >= 0.26.0 #783
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Yes, would nice, we also can't update our lib without this |
Flo0807
reviewed
Sep 16, 2025
mix.exs
Outdated
| {:tzdata, "~> 1.1"}, | ||
| {:combine, "~> 0.10"}, | ||
| {:gettext, "~> 0.26"}, | ||
| {:gettext, "~> 1.0"}, |
There was a problem hiding this comment.
This forces applications to use Gettext v1.0 or higher. As there are no breaking changes and "very few changes from the latest 0.26 release", we might want to set the constraint to something like this:
Suggested change
| {:gettext, "~> 1.0"}, | |
| {:gettext, ">= 0.26.0"}, |
There was a problem hiding this comment.
Yeah, good suggestion. Thanks 👍
This allows users to choose between gettext 0.26.x and 1.0.x versions, maintaining backward compatibility while enabling forward compatibility.
patrols
force-pushed
the
update-gettext-1.0
branch
from
b07e063 to
aa4d7a9
Compare
patrols
changed the title
|
+1. Can we merge it? |
|
Would be really nice! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes
Relax gettext dependency constraint to allow >= 0.26.0
This allows users to choose between gettext 0.26.x and 1.0.x versions
gettext 1.0.0 changelog
Checklist
Fixes #782