PM-26577: Support multiple schemes for Duo, WebAuthn, and SSO callbacks #6339
+240
−105
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
app:password-manager
app:authenticator
t:misc
and removed
ai-review
david-livefront
commented
Jan 8, 2026
| .getEncoder() | ||
| .encodeToString(json.toString().toByteArray(Charsets.UTF_8)) | ||
| val parentParam = URLEncoder.encode(CALLBACK_URI, "UTF-8") | ||
| val parentParam = URLEncoder.encode(callbackUri, "UTF-8") |
Collaborator
Author
There was a problem hiding this comment.
This parent param is required by the WebAuthn Connector but it does not really use the value.
I have an open question about what I should be sending here.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #6339 +/- ##
=======================================
Coverage 85.49% 85.49%
=======================================
Files 764 764
Lines 54724 54741 +17
Branches 7881 7884 +3
=======================================
+ Hits 46785 46802 +17
Misses 5201 5201
Partials 2738 2738 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
david-livefront
force-pushed
the
PM-26577-app-links-support
branch
from
795738e to
60679da
Compare
david-livefront
changed the title
Contributor
|
Great job! No new security vulnerabilities introduced in this pull request |
david-livefront
force-pushed
the
PM-26577-app-links-support
branch
from
60679da to
fc73da8
Compare
david-livefront
force-pushed
the
PM-26577-app-links-support
branch
from
fc73da8 to
1174c47
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎟️ Tracking
PM-26577
📔 Objective
This PR updates the Duo and WebAuthn logic to send the appropriate deeplink scheme data.
Note: This PR is on hold until the WebConnector logic is updated.
⏰ Reminders before review
🦮 Reviewer guidelines
:+1:) or similar for great changes:memo:) or ℹ️ (:information_source:) for notes or general info:question:) for questions:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion:art:) for suggestions / improvements:x:) or:warning:) for more significant problems or concerns needing attention:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt:pick:) for minor or nitpick changes