Skip to content

Conversation

@shamim-emon
Copy link

🎟️ Tracking

#6306

📔 Objective

FIxes Unlock with PIN doesn’t appear as enabled after enabling ‘Require master password on app restart’.

📸 Screenshots

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

@shamim-emon shamim-emon requested review from a team and david-livefront as code owners January 11, 2026 10:13
@bitwarden-bot
Copy link

Thank you for your contribution! We've added this to our internal tracking system for review.
ID: PM-30664
Link: https://bitwarden.atlassian.net/browse/PM-30664

Details on our contribution process can be found here: https://contributing.bitwarden.com/contributing/pull-requests/community-pr-process.

@bitwarden-bot bitwarden-bot changed the title Unlock with PIN doesn’t appear as enabled after enabling ‘Require master password on app restart’ [PM-30664] Unlock with PIN doesn’t appear as enabled after enabling ‘Require master password on app restart’ Jan 11, 2026
@shamim-emon shamim-emon force-pushed the fix-issue-6306 branch 2 times, most recently from 64b54fd to 53e44c4 Compare January 11, 2026 14:22
@shamim-emon
Copy link
Author

Hello @david-livefront, this is my first PR for Bitwarden Android. I’m encountering a CI failure related to READ-level permissions.

I initially updated my classic permission token to include package:write, but the issue persisted. I then reverted it back to package:read as mentioned in the README.

I’m wondering if this is expected behavior for a first-time contributor and requires approval from a code owner, or if there’s something else I need to do on my end.

Please let me know. Thank you!

@SaintPatrck
Copy link
Contributor

Hi @shamim-emon

Thank you for submitting this pull request. For security reasons, all workflows on community PR's require maintainer approval before they run. We will trigger checks once we've reviewed the changes.

@shamim-emon
Copy link
Author

Hi @shamim-emon

Thank you for submitting this pull request. For security reasons, all workflows on community PR's require maintainer approval before they run. We will trigger checks once we've reviewed the changes.

Hello @SaintPatrck thank you for the clarification. I’ll await your feedback!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants