Skip to content

Support for SharpRaven 2.1.0 (and with it support for asynchronous communication) #11

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Support for SharpRaven 2.1.0 (and with it support for asynchronous communication) #11

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
685125f
Updated dependecy for SharpRaven to version 2.1.
Dec 22, 2016
adfde60
Starting to use Capture functions for supporting async communication
Dec 22, 2016
98d2183
Updated Readme for to show how to use async communication
Dec 22, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion NLog.Targets.Sentry.UnitTests/packages.config
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,5 +4,5 @@
<package id="Newtonsoft.Json" version="6.0.6" targetFramework="net45" />
<package id="NLog" version="3.2.0.0" targetFramework="net45" />
<package id="NUnit" version="2.6.4" targetFramework="net45" />
<package id="SharpRaven" version="1.4.3" targetFramework="net45" />
<package id="SharpRaven" version="2.1.0" targetFramework="net45" />
</packages>
2 changes: 1 addition & 1 deletion NLog.Targets.Sentry/Packages.config
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,5 +2,5 @@
<packages>
<package id="Newtonsoft.Json" version="6.0.6" targetFramework="net45" />
<package id="NLog" version="3.2.0.0" targetFramework="net45" />
<package id="SharpRaven" version="1.4.3" targetFramework="net45" />
<package id="SharpRaven" version="2.1.0" targetFramework="net45" />
</packages>
17 changes: 13 additions & 4 deletions NLog.Targets.Sentry/SentryTarget.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -88,13 +88,22 @@ protected override void Write(LogEventInfo logEvent)
// those kinds of events then we'll send a "Message" to Sentry
if (logEvent.Exception == null && !IgnoreEventsWithNoException)
{
var sentryMessage = new SentryMessage(Layout.Render(logEvent));
client.Value.CaptureMessage(sentryMessage, LoggingLevelMap[logEvent.Level], extra: extras, tags: tags);
var sentryEvent = new SentryEvent(new SentryMessage(Layout.Render(logEvent)))
{
Level = LoggingLevelMap[logEvent.Level],
Extra = extras
};
client.Value.Capture(sentryEvent);
}
else if (logEvent.Exception != null)
{
var sentryMessage = new SentryMessage(logEvent.FormattedMessage);
client.Value.CaptureException(logEvent.Exception, extra: extras, level: LoggingLevelMap[logEvent.Level], message: sentryMessage, tags: tags);
var sentryEvent = new SentryEvent(logEvent.Exception)
{
Level = LoggingLevelMap[logEvent.Level],
Extra = extras,
Message = new SentryMessage(logEvent.FormattedMessage)
};
client.Value.Capture(sentryEvent);
}
}
catch (Exception e)
Expand Down
2 changes: 1 addition & 1 deletion README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ To use the Sentry target, simply add it an extension in the NLog.config file and
<add assembly="NLog.Targets.Sentry" />
</extensions>

<targets>
<targets async="true">
<target name="Sentry" type="Sentry" dsn="<your sentry dsn>"/>
</targets>

Expand Down