Skip to content

Conversation

tokusyu
Copy link
Contributor

@tokusyu tokusyu commented Jun 24, 2019

  1. The format of address in genesis transaction for BitcoinCash has been legacy style like "1A1zP1eP5QGefi2DMPTfTL5SLmv7DivfNa", but should be CashAddr style like "bitcoincash:qp3wjpa3tjlj042z2wv7hahsldgwhwy0rq9sywjpyy" to be aligned with other BitcoinCash transactions.
    https://cashaddr.bitcoincash.org

  2. BitcoinCash node software has supported "getblock with verbosity = 2" option since v0.18.8.
    https://github.com/Bitcoin-ABC/bitcoin-abc/releases/tag/v0.18.8
    To gain ETL performance, "bitcoin_cash" should be removed from "HAVE_OLD_API" list in chain.py.

@medvedev1088
Copy link
Member

Thanks for this PR! I will make sure first that we run v0.18.8 then will merge this PR.

DarrenLuo pushed a commit to coinfound/bitcoin-etl that referenced this pull request Sep 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants