Broadcast newmaster from watcher-thread #5306
Open
+103
−18
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
roborivers
suggested changes
Aug 5, 2025
roborivers
left a comment
roborivers
left a comment
There was a problem hiding this comment.
Coding style check: Success ✓.
Smoke testing: Success ✓.
Cbuild submission: Success ✓.
Regression testing: 2/620 tests failed ⚠.
The first 10 failing tests are:
catchup
reco-ddlk-sql
markhannum
force-pushed
the
watcher_newmaster
branch
3 times, most recently
from
e348607 to
00f2d0b
Compare
roborivers
suggested changes
Aug 5, 2025
roborivers
left a comment
roborivers
left a comment
There was a problem hiding this comment.
Coding style check: Error. ⚠.
Smoke testing: Error ⚠.
Cbuild submission: Success ✓.
Regression testing: 3/620 tests failed ⚠.
The first 10 failing tests are:
close_old_connections [setup failure]
sc_lotsoftables_logicalsc_generated
sc_lotsoftables
riverszhang89
previously approved these changes
Sep 12, 2025
Contributor
|
Does this need more work, or ready to merge? |
markhannum
force-pushed
the
watcher_newmaster
branch
from
00f2d0b to
5578e64
Compare
markhannum
force-pushed
the
watcher_newmaster
branch
2 times, most recently
from
a3ff7af to
dc06a07
Compare
Acquire generation under rep_mutexp Physreps should respond to 3 lowgen reqs Set-last-locked lsn in skip recovery Signed-off-by: Mark Hannum <[email protected]>
markhannum
force-pushed
the
watcher_newmaster
branch
from
dc06a07 to
859e89c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a case where incoherent physical replicants request log-records on a lower generation than the current master's generation.