Javascript 2

[hillal20]

No description provided.

[indifferentghost]

JavaScript-ii\src\class.js
  17:3   error  Block must not be padded by blank lines                                       padded-blocks
  22:5   error  Closing curly brace does not appear on the same line as the subsequent block  brace-style
  22:5   error  Block must not be padded by blank lines                                       padded-blocks
  23:10  error  Unnecessary 'else' after 'return'                                             no-else-return
  56:7   error  Expected 'this' to be used by class method 'meow'                             class-methods-use-this
  57:12  error  Unexpected template string expression                                         no-template-curly-in-string
  57:34  error  Missing semicolon                                                             semi

JavaScript-ii\src\prototype.js
   11:1   error    Trailing spaces not allowed                           no-trailing-spaces
   58:10  error    Expected 'this' to be used by class method 'destroy'  class-methods-use-this
   73:10  error    Expected 'this' to be used by class method 'destroy'  class-methods-use-this
   87:10  error    Expected 'this' to be used by class method 'destroy'  class-methods-use-this
   96:5   error    'hilal' is never reassigned. Use 'const' instead      prefer-const
  107:1   warning  Unexpected console statement                          no-console
  108:1   warning  Unexpected console statement                          no-console

JavaScript-ii\src\recursion.js
  9:47  error  Missing semicolon  semi

JavaScript-ii\src\this.js
  16:17  error  Parsing error: Unexpected token =
  11:21  error    'password' is not defined                                                     no-undef
  19:5   error    Closing curly brace does not appear on the same line as the subsequent block  brace-style
  20:10  error    Unnecessary 'else' after 'return'                                             no-else-return
  40:3   error    'checkPassword' is constant                                                   no-const-assign
  40:19  warning  Unexpected unnamed function                                                   func-names
  43:5   error    Closing curly brace does not appear on the same line as the subsequent block  brace-style
  44:10  error    Unnecessary 'else' after 'return'                                             no-else-return
  47:4   error    Missing semicolon                                                             semi
  49:1   error    Block must not be padded by blank lines                                       padded-blocks
  55:26  error    'string' is not defined                                                       no-undef
  58:27  error    'arr' is not defined                                                          no-undef
  58:31  error    Missing semicolon                                                             semi
  61:1   error    'newfFunction' is not defined                                                 no-undef
  61:44  error    'arr' is not defined                                                          no-undef
  61:48  error    Missing semicolon                                                             semi
  62:1   error    'newFuncrtion' is not defined                                                 no-undef

What am I suppose to do with this? It's clear you understand the syntax, but there's no way I could run the code?

Great

Your whitespace and indentation has immensely improved. You seem to understand the basics of JavaScript, but if you attempted to submit this pull request on an actual project they'd reject it.

Requested Improvements

You have to fix linting errors. There's actual code that won't run even with the linter disabled.

Questions

Your code is usually more precise then this. Is this the latest version of JavaScript-II?

Rating: {1-3}

1.5

[hillal20]

No it is not this one. Josh told us to commit once in a while early , and keep doing the job untill the final version we pull request it.

…

On Fri, Mar 23, 2018, 2:35 PM Thomas Dillard ***@***.***> wrote: [image: Boxbe] <https://www.boxbe.com/overview> Thomas Dillard ( ***@***.***) is not on your Guest List <https://www.boxbe.com/approved-list?tc_serial=37752033520&tc_rand=1195664583&utm_source=stf&utm_medium=email&utm_campaign=ANNO_MWTP&utm_content=001&key=oQXtSzMAmwKL%2BTuRSJ%2F0E4ZgZF9rs576dkT2SZILOy0%3D&token=m%2Br6z%2BFJlqDJJT%2BZkFaL7JPJ8m7VBe%2FQBMF1EeeVxErB1Pam%2B3waQYirCJdkYuJa> | Approve sender <https://www.boxbe.com/anno?tc_serial=37752033520&tc_rand=1195664583&utm_source=stf&utm_medium=email&utm_campaign=ANNO_MWTP&utm_content=001&key=oQXtSzMAmwKL%2BTuRSJ%2F0E4ZgZF9rs576dkT2SZILOy0%3D&token=m%2Br6z%2BFJlqDJJT%2BZkFaL7JPJ8m7VBe%2FQBMF1EeeVxErB1Pam%2B3waQYirCJdkYuJa> | Approve domain <https://www.boxbe.com/anno?tc_serial=37752033520&tc_rand=1195664583&utm_source=stf&utm_medium=email&utm_campaign=ANNO_MWTP&utm_content=001&dom&key=oQXtSzMAmwKL%2BTuRSJ%2F0E4ZgZF9rs576dkT2SZILOy0%3D&token=m%2Br6z%2BFJlqDJJT%2BZkFaL7JPJ8m7VBe%2FQBMF1EeeVxErB1Pam%2B3waQYirCJdkYuJa> ***@***.**** requested changes on this pull request. JavaScript-ii\src\class.js 17:3 error Block must not be padded by blank lines padded-blocks 22:5 error Closing curly brace does not appear on the same line as the subsequent block brace-style 22:5 error Block must not be padded by blank lines padded-blocks 23:10 error Unnecessary 'else' after 'return' no-else-return 56:7 error Expected 'this' to be used by class method 'meow' class-methods-use-this 57:12 error Unexpected template string expression no-template-curly-in-string 57:34 error Missing semicolon semi JavaScript-ii\src\prototype.js 11:1 error Trailing spaces not allowed no-trailing-spaces 58:10 error Expected 'this' to be used by class method 'destroy' class-methods-use-this 73:10 error Expected 'this' to be used by class method 'destroy' class-methods-use-this 87:10 error Expected 'this' to be used by class method 'destroy' class-methods-use-this 96:5 error 'hilal' is never reassigned. Use 'const' instead prefer-const 107:1 warning Unexpected console statement no-console 108:1 warning Unexpected console statement no-console JavaScript-ii\src\recursion.js 9:47 error Missing semicolon semi JavaScript-ii\src\this.js 16:17 error Parsing error: Unexpected token = 11:21 error 'password' is not defined no-undef 19:5 error Closing curly brace does not appear on the same line as the subsequent block brace-style 20:10 error Unnecessary 'else' after 'return' no-else-return 40:3 error 'checkPassword' is constant no-const-assign 40:19 warning Unexpected unnamed function func-names 43:5 error Closing curly brace does not appear on the same line as the subsequent block brace-style 44:10 error Unnecessary 'else' after 'return' no-else-return 47:4 error Missing semicolon semi 49:1 error Block must not be padded by blank lines padded-blocks 55:26 error 'string' is not defined no-undef 58:27 error 'arr' is not defined no-undef 58:31 error Missing semicolon semi 61:1 error 'newfFunction' is not defined no-undef 61:44 error 'arr' is not defined no-undef 61:48 error Missing semicolon semi 62:1 error 'newFuncrtion' is not defined no-undef What am I suppose to do with this? It's clear you understand the syntax, but there's no way I could run the code? Great Your whitespace and indentation has immensely improved. You seem to understand the basics of JavaScript, but if you attempted to submit this pull request on an actual project they'd reject it. Requested Improvements You have to fix linting errors. There's actual code that won't run even with the linter disabled. Questions Your code is usually more precise then this. Is this the latest version of JavaScript-II? Rating: {1-3} 1.5 — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <bloominstituteoftechnology/JavaScript-II#217 (review)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AZIJqrQvx3OxAhNq227NLlOPcu8G5Hm1ks5thT3UgaJpZM4S2WZU> .