-
Notifications
You must be signed in to change notification settings - Fork 42
update deps, golangci-lint version: #426
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
jacobweinstock
wants to merge
4
commits into
bmc-toolbox:main
Choose a base branch
from
jacobweinstock:xnet-update
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,125 +1,20 @@ | ||
| govet: | ||
| auto-fix: true | ||
| linters-settings: | ||
| enable: | ||
| - fieldalignment | ||
| check-shadowing: true | ||
| settings: | ||
| printf: | ||
| funcs: | ||
| - (github.com/golangci/golangci-lint/pkg/logutils.Log).Infof | ||
| - (github.com/golangci/golangci-lint/pkg/logutils.Log).Warnf | ||
| - (github.com/golangci/golangci-lint/pkg/logutils.Log).Errorf | ||
| - (github.com/golangci/golangci-lint/pkg/logutils.Log).Fatalf | ||
| golint: | ||
| min-confidence: 0 | ||
| gocyclo: | ||
| min-complexity: 10 | ||
| maligned: | ||
| suggest-new: true | ||
| dupl: | ||
| threshold: 100 | ||
| goconst: | ||
| min-len: 2 | ||
| min-occurrences: 2 | ||
| depguard: | ||
| list-type: blacklist | ||
| packages: | ||
| # logging is allowed only by logutils.Log, logrus | ||
| # is allowed to use only in logutils package | ||
| - github.com/sirupsen/logrus | ||
| misspell: | ||
| locale: US | ||
| auto-fix: true | ||
| lll: | ||
| line-length: 140 | ||
| goimports: | ||
| local-prefixes: github.com/golangci/golangci-lint | ||
| gocritic: | ||
| auto-fix: true | ||
| enabled-tags: | ||
| - performance | ||
| - style | ||
| - experimental | ||
| disabled-checks: | ||
| - wrapperFunc | ||
| gofumpt: | ||
| extra-rules: true | ||
| auto-fix: true | ||
| wsl: | ||
| auto-fix: true | ||
| stylecheck: | ||
| auto-fix: true | ||
|
|
||
| version: "2" | ||
| linters: | ||
| enable: | ||
| - errcheck | ||
| - gosimple | ||
| - govet | ||
| - gofmt | ||
| - gocyclo | ||
| - ineffassign | ||
| - stylecheck | ||
| - deadcode | ||
| - staticcheck | ||
| - structcheck | ||
| - unused | ||
| - prealloc | ||
| - typecheck | ||
| - varcheck | ||
| # additional linters | ||
| - bodyclose | ||
| - gocritic | ||
| - whitespace | ||
| - wsl | ||
| - goimports | ||
| - golint | ||
| - misspell | ||
| - goerr113 | ||
| - noctx | ||
| enable-all: false | ||
| disable-all: true | ||
|
|
||
| run: | ||
| skip-dirs: | ||
|
|
||
|
|
||
| issues: | ||
| exclude-rules: | ||
| - linters: | ||
| - gosec | ||
| text: "weak cryptographic primitive" | ||
|
|
||
| - linters: | ||
| - stylecheck | ||
| text: "ST1016" | ||
| exclude: | ||
| # Default excludes from `golangci-lint run --help` with EXC0002 removed | ||
| # EXC0001 errcheck: Almost all programs ignore errors on these functions and in most cases it's ok | ||
| - Error return value of .((os\.)?std(out|err)\..*|.*Close|.*Flush|os\.Remove(All)?|.*print(f|ln)?|os\.(Un)?Setenv). is not checked | ||
| # EXC0002 golint: Annoying issue about not having a comment. The rare codebase has such comments | ||
| # - (comment on exported (method|function|type|const)|should have( a package)? comment|comment should be of the form) | ||
| # EXC0003 golint: False positive when tests are defined in package 'test' | ||
| - func name will be used as test\.Test.* by other packages, and that stutters; consider calling this | ||
| # EXC0004 govet: Common false positives | ||
| - (possible misuse of unsafe.Pointer|should have signature) | ||
| # EXC0005 staticcheck: Developers tend to write in C-style with an explicit 'break' in a 'switch', so it's ok to ignore | ||
| - ineffective break statement. Did you mean to break out of the outer loop | ||
| # EXC0006 gosec: Too many false-positives on 'unsafe' usage | ||
| - Use of unsafe calls should be audited | ||
| # EXC0007 gosec: Too many false-positives for parametrized shell calls | ||
| - Subprocess launch(ed with variable|ing should be audited) | ||
| # EXC0008 gosec: Duplicated errcheck checks | ||
| - (G104|G307) | ||
| # EXC0009 gosec: Too many issues in popular repos | ||
| - (Expect directory permissions to be 0750 or less|Expect file permissions to be 0600 or less) | ||
| # EXC0010 gosec: False positive is triggered by 'src, err := ioutil.ReadFile(filename)' | ||
| - Potential file inclusion via variable | ||
| exclude-use-default: false | ||
|
|
||
| # golangci.com configuration | ||
| # https://github.com/golangci/golangci/wiki/Configuration | ||
| #service: | ||
| # golangci-lint-version: 1.15.x # use the fixed version to not introduce new linters unexpectedly | ||
| # prepare: | ||
| # - echo "here I can run custom commands, but no preparation needed for this repo" | ||
| exclusions: | ||
| generated: lax | ||
| presets: | ||
| - comments | ||
| - common-false-positives | ||
| - legacy | ||
| - std-error-handling | ||
| paths: | ||
| - third_party$ | ||
| - builtin$ | ||
| - examples/ | ||
| formatters: | ||
| exclusions: | ||
| generated: lax | ||
| paths: | ||
| - third_party$ | ||
| - builtin$ | ||
| - examples/ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there a reason to remove the linter action from here?