Skip to content

Conversation

@jedel1043
Copy link
Member

Fixes #4493.
Depends on #4495.

This PR improves strictness on the implementations of Map and Set by ensuring borrows are as small as possible, and also by reimplementing our lock structs to be a bit less sporadic about when they lock and unlock the underlying map.

Additionally, it cleans up our implementations to use newer APIs such as the js_error macro, upcast/downcast, etc.

@jedel1043 jedel1043 requested a review from a team October 25, 2025 20:21
@jedel1043 jedel1043 added bug Something isn't working Internal Category for changelog labels Oct 25, 2025
@github-actions
Copy link

github-actions bot commented Oct 25, 2025

Test262 conformance changes

Test result main count PR count difference
Total 50,595 50,595 0
Passed 47,678 47,678 0
Ignored 2,036 2,036 0
Failed 881 881 0
Panics 0 0 0
Conformance 94.23% 94.23% 0.00%

@codecov
Copy link

codecov bot commented Oct 25, 2025

Codecov Report

❌ Patch coverage is 82.16561% with 56 lines in your changes missing coverage. Please review.
✅ Project coverage is 57.13%. Comparing base (6ddc2b4) to head (2a3fd05).
⚠️ Report is 579 commits behind head on main.

Files with missing lines Patch % Lines
core/engine/src/object/builtins/jsset.rs 16.66% 20 Missing ⚠️
core/engine/src/builtins/map/mod.rs 81.37% 19 Missing ⚠️
core/engine/src/builtins/set/mod.rs 86.92% 17 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4497      +/-   ##
==========================================
+ Coverage   47.24%   57.13%   +9.89%     
==========================================
  Files         476      503      +27     
  Lines       46892    57347   +10455     
==========================================
+ Hits        22154    32768   +10614     
+ Misses      24738    24579     -159     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@jedel1043 jedel1043 marked this pull request as ready for review October 26, 2025 16:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working Internal Category for changelog

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Fatal Crash/Panic in map/ordered_map.rs:225

1 participant