Migrate FsTzdbProvider to timezone_provider
#307
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nekevss
changed the title
FsTzdbProvider to to timezone_providerFsTzdbProvider to timezone_provider
nekevss
added
providers
|
Closing this PR as it's stale and will be easier to start form scratch |
github-project-automation
bot
moved this from In review
to Done
in Temporal Implementation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Posting as a draft.
There's still more work to be completed, specifically around migrating to the adjusted
TimeZoneProvidertrait.Overall, this migration is probably blocked by #257, #264, and #265, so that those can be turned on during this migration (although, there is definitely a valid argument to keep the dependency on
jiff_tzdbfor now to unblock this).