Skip to content

Conversation

gummif
Copy link
Contributor

@gummif gummif commented Oct 11, 2022

This is for inserting values at any position in the object preserving order of all elements (at the cost of linear complexity). Part 2/2 of #748.

This does not have the bug #763 since care is taken to avoid allocation unless necessary.

@codecov
Copy link

codecov bot commented Oct 11, 2022

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 98.97%. Comparing base (ce144b5) to head (d854374).
⚠️ Report is 314 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #765      +/-   ##
===========================================
- Coverage    99.13%   98.97%   -0.17%     
===========================================
  Files           69       69              
  Lines         6587     6623      +36     
===========================================
+ Hits          6530     6555      +25     
- Misses          57       68      +11     
Files with missing lines Coverage Δ
include/boost/json/impl/object.hpp 100.00% <100.00%> (ø)
include/boost/json/impl/object.ipp 100.00% <100.00%> (ø)
include/boost/json/object.hpp 100.00% <ø> (ø)

... and 2 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ce144b5...d854374. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@cppalliance-bot
Copy link

@gummif
Copy link
Contributor Author

gummif commented Oct 12, 2022

One thing that could reduce duplication is to implement insert in terms of stable_insert_impl using pos as end().

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants