standalone lib for use with vanilla js in the browser #18
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
+1 |
Closed
|
@FalconerTC : Did you manage to make the plugin work ? I'm still having some trouble. |
|
@Astriel It did work for me. What is the issue you are having? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adjusts the Makefile to export the SonicServer, SonicSocket and SonicCoder under a global Sonicnet object attached to
window. This is in addition to the dependency manager hooks which browserify exposes. See details about--standaloneflag.This fixes
lib/api-test.htmland makes it practical to consume the library in a browser in the absence of a dependency manager.I wasn't able to find a solution to configure browserify to export the individual objects directly to
windowwithout explicitly changinglib/main.jsas attempted in @mildmojo's PR.This changes only the build in
lib/. The Makefiles for the demos are left unchanged.