Add more k8s settings #689
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Kush Upadhyay <[email protected]>
Signed-off-by: Kush Upadhyay <[email protected]>
piyush-jena
approved these changes
Oct 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue number:
bottlerocket-os/bottlerocket#4058
bottlerocket-os/bottlerocket#4453
bottlerocket-os/bottlerocket#4544
bottlerocket-os/bottlerocket#4643
Description of changes:
Add the following settings to the relevant kubelet configs:
enableDebuggingHandlers: Defaulting tofalseas originally it's set to true. I see refs of this setting earlier than k8s 1.28, so adding this to all k8s versions we currently support -> 1.28-1.34imageMinimumGCAge: I see refs of this setting earlier than k8s 1.28, so adding this to all k8s versions we currently support -> 1.28-1.34imageMaximumGCAge: This is behind a feature gate in 1.29, but defaults to true 1.30+maxParallelImagePulls: Added in k8s 1.27, so adding to all of our versions 1.28-1.34idsperPod: Added in k8s 1.33, so only adding to 1.33 and 1.34 configsWIP:
settings-modelsversion bump after new settings-sdk releaseRelated:
Testing done:
See Testing Description section here: bottlerocket-os/bottlerocket-settings-sdk#104
Terms of contribution:
By submitting this pull request, I agree that this contribution is dual-licensed under the terms of both the Apache License, version 2.0, and the MIT license.