[ButtonMenu]: BREAKING Fix `min-width` variable and close via click outside #776

fallaciousreasoning · 2024-08-12T21:15:43Z

No description provided.

github-actions · 2024-08-12T21:18:23Z

👋 Thanks for Submitting! This PR is available for preview at the link below.

✅ PR tip preview: https://776.pr.nala.bravesoftware.com/
✅ Commit preview: https://776.pr.nala.bravesoftware.com/commit-5af67cb8fceea3a2661723ed21044e888f9a2624/

- ./tokens/css/variables-android.old.css: 7424 bytes
+ ./tokens/css/variables-android.css: 7424 bytes
---
- ./tokens/css/variables-browser.old.css: 6670 bytes
+ ./tokens/css/variables-browser.css: 6670 bytes
---
- ./tokens/css/variables-ios.old.css: 7067 bytes
+ ./tokens/css/variables-ios.css: 7067 bytes
---
- ./tokens/css/variables-marketing.old.css: 13561 bytes
+ ./tokens/css/variables-marketing.css: 13561 bytes
---
- ./tokens/css/variables-news.old.css: 526 bytes
+ ./tokens/css/variables-news.css: 526 bytes
---
- ./tokens/css/variables-newtab.old.css: 1941 bytes
+ ./tokens/css/variables-newtab.css: 1941 bytes
---
- ./tokens/css/variables-search.old.css: 2419 bytes
+ ./tokens/css/variables-search.css: 2419 bytes
---
- ./tokens/css/variables-web3.old.css: 833 bytes
+ ./tokens/css/variables-web3.css: 833 bytes
---
- ./tokens/css/variables.old.css: 111822 bytes
+ ./tokens/css/variables.css: 111822 bytes

Variables Diff: variables-android.diff

--- ./tokens/css/variables-android.old.css	2024-08-12 21:17:01.180294717 +0000
+++ ./tokens/css/variables-android.css	2024-08-12 21:16:23.656394701 +0000
@@ -1,6 +1,6 @@
 /**
  * Do not edit directly
- * Generated on Wed Aug 07 2024 21:26:19 GMT+0000 (Coordinated Universal Time)
+ * Generated on Mon Aug 12 2024 21:16:23 GMT+0000 (Coordinated Universal Time)
  */
 
 :root {

Variables Diff: variables-browser.diff

--- ./tokens/css/variables-browser.old.css	2024-08-12 21:17:01.556293992 +0000
+++ ./tokens/css/variables-browser.css	2024-08-12 21:16:23.636394724 +0000
@@ -1,6 +1,6 @@
 /**
  * Do not edit directly
- * Generated on Wed Aug 07 2024 21:26:19 GMT+0000 (Coordinated Universal Time)
+ * Generated on Mon Aug 12 2024 21:16:23 GMT+0000 (Coordinated Universal Time)
  */
 
 :root {

Variables Diff: variables-ios.diff

--- ./tokens/css/variables-ios.old.css	2024-08-12 21:17:01.924293285 +0000
+++ ./tokens/css/variables-ios.css	2024-08-12 21:16:23.672394682 +0000
@@ -1,6 +1,6 @@
 /**
  * Do not edit directly
- * Generated on Wed Aug 07 2024 21:26:19 GMT+0000 (Coordinated Universal Time)
+ * Generated on Mon Aug 12 2024 21:16:23 GMT+0000 (Coordinated Universal Time)
  */
 
 :root {

Variables Diff: variables-marketing.diff

--- ./tokens/css/variables-marketing.old.css	2024-08-12 21:17:02.288292584 +0000
+++ ./tokens/css/variables-marketing.css	2024-08-12 21:16:23.692394659 +0000
@@ -1,6 +1,6 @@
 /**
  * Do not edit directly
- * Generated on Wed Aug 07 2024 21:26:19 GMT+0000 (Coordinated Universal Time)
+ * Generated on Mon Aug 12 2024 21:16:23 GMT+0000 (Coordinated Universal Time)
  */
 
 :root {

Variables Diff: variables-news.diff

--- ./tokens/css/variables-news.old.css	2024-08-12 21:17:02.668291853 +0000
+++ ./tokens/css/variables-news.css	2024-08-12 21:16:23.716394631 +0000
@@ -1,6 +1,6 @@
 /**
  * Do not edit directly
- * Generated on Wed Aug 07 2024 21:26:19 GMT+0000 (Coordinated Universal Time)
+ * Generated on Mon Aug 12 2024 21:16:23 GMT+0000 (Coordinated Universal Time)
  */
 
 :root {

Variables Diff: variables-newtab.diff

--- ./tokens/css/variables-newtab.old.css	2024-08-12 21:17:03.048291122 +0000
+++ ./tokens/css/variables-newtab.css	2024-08-12 21:16:23.724394622 +0000
@@ -1,6 +1,6 @@
 /**
  * Do not edit directly
- * Generated on Wed Aug 07 2024 21:26:19 GMT+0000 (Coordinated Universal Time)
+ * Generated on Mon Aug 12 2024 21:16:23 GMT+0000 (Coordinated Universal Time)
  */
 
 :root {

Variables Diff: variables-search.diff

--- ./tokens/css/variables-search.old.css	2024-08-12 21:17:03.388290468 +0000
+++ ./tokens/css/variables-search.css	2024-08-12 21:16:23.712394636 +0000
@@ -1,6 +1,6 @@
 /**
  * Do not edit directly
- * Generated on Wed Aug 07 2024 21:26:19 GMT+0000 (Coordinated Universal Time)
+ * Generated on Mon Aug 12 2024 21:16:23 GMT+0000 (Coordinated Universal Time)
  */
 
 :root {

Variables Diff: variables-web3.diff

--- ./tokens/css/variables-web3.old.css	2024-08-12 21:17:03.732289806 +0000
+++ ./tokens/css/variables-web3.css	2024-08-12 21:16:23.732394612 +0000
@@ -1,6 +1,6 @@
 /**
  * Do not edit directly
- * Generated on Wed Aug 07 2024 21:26:19 GMT+0000 (Coordinated Universal Time)
+ * Generated on Mon Aug 12 2024 21:16:23 GMT+0000 (Coordinated Universal Time)
  */
 
 @media (prefers-color-scheme: light) {

Variables Diff: variables.diff

--- ./tokens/css/variables.old.css	2024-08-12 21:17:04.280288753 +0000
+++ ./tokens/css/variables.css	2024-08-12 21:16:23.496394888 +0000
@@ -1,6 +1,6 @@
 /**
  * Do not edit directly
- * Generated on Wed Aug 07 2024 21:26:19 GMT+0000 (Coordinated Universal Time)
+ * Generated on Mon Aug 12 2024 21:16:23 GMT+0000 (Coordinated Universal Time)
  */
 
 :root {

nullhook · 2024-08-13T09:26:56Z

src/components/buttonMenu/buttonMenu.svelte

+  const handleClose = (e: CloseEventDetail) => {
+    if (isOpen === undefined) isOpenInternal = false
+    onClose?.(e)
+  }


the state wasn't being updated onClose and therefore the menu took multiple clicks to open again?

Exactly, yeah 😄

nullhook · 2024-08-13T09:28:45Z

src/components/menu/menu.svelte

  }

  .leo-menu .leo-menu-popup {
+    --min-width: var(--leo-menu-control-min-width, var(--leo-menu-target-width));


brave rewards codebase uses the previous name so we will need to change it to this when updating nala

Good to know!

src/components/buttonMenu/buttonMenu.svelte

github-actions · 2024-08-14T01:36:22Z

👋 Thanks for Submitting! This PR is available for preview at the link below.

✅ PR tip preview: https://776.pr.nala.bravesoftware.com/
✅ Commit preview: https://776.pr.nala.bravesoftware.com/commit-c84915703f3394c739d12629ebaf313692c92f03/

- ./tokens/css/variables-android.old.css: 7424 bytes
+ ./tokens/css/variables-android.css: 7424 bytes
---
- ./tokens/css/variables-browser.old.css: 6670 bytes
+ ./tokens/css/variables-browser.css: 6670 bytes
---
- ./tokens/css/variables-ios.old.css: 7067 bytes
+ ./tokens/css/variables-ios.css: 7067 bytes
---
- ./tokens/css/variables-marketing.old.css: 13561 bytes
+ ./tokens/css/variables-marketing.css: 13561 bytes
---
- ./tokens/css/variables-news.old.css: 526 bytes
+ ./tokens/css/variables-news.css: 526 bytes
---
- ./tokens/css/variables-newtab.old.css: 1941 bytes
+ ./tokens/css/variables-newtab.css: 1941 bytes
---
- ./tokens/css/variables-search.old.css: 2419 bytes
+ ./tokens/css/variables-search.css: 2419 bytes
---
- ./tokens/css/variables-web3.old.css: 833 bytes
+ ./tokens/css/variables-web3.css: 833 bytes
---
- ./tokens/css/variables.old.css: 111822 bytes
+ ./tokens/css/variables.css: 111822 bytes

Variables Diff: variables-android.diff

--- ./tokens/css/variables-android.old.css	2024-08-14 01:34:49.547195602 +0000
+++ ./tokens/css/variables-android.css	2024-08-14 01:34:11.630928361 +0000
@@ -1,6 +1,6 @@
 /**
  * Do not edit directly
- * Generated on Tue Aug 13 2024 21:21:52 GMT+0000 (Coordinated Universal Time)
+ * Generated on Wed Aug 14 2024 01:34:11 GMT+0000 (Coordinated Universal Time)
  */
 
 :root {

Variables Diff: variables-browser.diff

--- ./tokens/css/variables-browser.old.css	2024-08-14 01:34:49.895197957 +0000
+++ ./tokens/css/variables-browser.css	2024-08-14 01:34:11.614928176 +0000
@@ -1,6 +1,6 @@
 /**
  * Do not edit directly
- * Generated on Tue Aug 13 2024 21:21:52 GMT+0000 (Coordinated Universal Time)
+ * Generated on Wed Aug 14 2024 01:34:11 GMT+0000 (Coordinated Universal Time)
  */
 
 :root {

Variables Diff: variables-ios.diff

--- ./tokens/css/variables-ios.old.css	2024-08-14 01:34:50.239200216 +0000
+++ ./tokens/css/variables-ios.css	2024-08-14 01:34:11.646928547 +0000
@@ -1,6 +1,6 @@
 /**
  * Do not edit directly
- * Generated on Tue Aug 13 2024 21:21:52 GMT+0000 (Coordinated Universal Time)
+ * Generated on Wed Aug 14 2024 01:34:11 GMT+0000 (Coordinated Universal Time)
  */
 
 :root {

Variables Diff: variables-marketing.diff

--- ./tokens/css/variables-marketing.old.css	2024-08-14 01:34:50.595202552 +0000
+++ ./tokens/css/variables-marketing.css	2024-08-14 01:34:11.670928825 +0000
@@ -1,6 +1,6 @@
 /**
  * Do not edit directly
- * Generated on Tue Aug 13 2024 21:21:52 GMT+0000 (Coordinated Universal Time)
+ * Generated on Wed Aug 14 2024 01:34:11 GMT+0000 (Coordinated Universal Time)
  */
 
 :root {

Variables Diff: variables-news.diff

--- ./tokens/css/variables-news.old.css	2024-08-14 01:34:50.947204862 +0000
+++ ./tokens/css/variables-news.css	2024-08-14 01:34:11.694929104 +0000
@@ -1,6 +1,6 @@
 /**
  * Do not edit directly
- * Generated on Tue Aug 13 2024 21:21:52 GMT+0000 (Coordinated Universal Time)
+ * Generated on Wed Aug 14 2024 01:34:11 GMT+0000 (Coordinated Universal Time)
  */
 
 :root {

Variables Diff: variables-newtab.diff

--- ./tokens/css/variables-newtab.old.css	2024-08-14 01:34:51.295207142 +0000
+++ ./tokens/css/variables-newtab.css	2024-08-14 01:34:11.702929197 +0000
@@ -1,6 +1,6 @@
 /**
  * Do not edit directly
- * Generated on Tue Aug 13 2024 21:21:52 GMT+0000 (Coordinated Universal Time)
+ * Generated on Wed Aug 14 2024 01:34:11 GMT+0000 (Coordinated Universal Time)
  */
 
 :root {

Variables Diff: variables-search.diff

--- ./tokens/css/variables-search.old.css	2024-08-14 01:34:51.615209242 +0000
+++ ./tokens/css/variables-search.css	2024-08-14 01:34:11.686929011 +0000
@@ -1,6 +1,6 @@
 /**
  * Do not edit directly
- * Generated on Tue Aug 13 2024 21:21:52 GMT+0000 (Coordinated Universal Time)
+ * Generated on Wed Aug 14 2024 01:34:11 GMT+0000 (Coordinated Universal Time)
  */
 
 :root {

Variables Diff: variables-web3.diff

--- ./tokens/css/variables-web3.old.css	2024-08-14 01:34:51.983211651 +0000
+++ ./tokens/css/variables-web3.css	2024-08-14 01:34:11.706929243 +0000
@@ -1,6 +1,6 @@
 /**
  * Do not edit directly
- * Generated on Tue Aug 13 2024 21:21:52 GMT+0000 (Coordinated Universal Time)
+ * Generated on Wed Aug 14 2024 01:34:11 GMT+0000 (Coordinated Universal Time)
  */
 
 @media (prefers-color-scheme: light) {

Variables Diff: variables.diff

--- ./tokens/css/variables.old.css	2024-08-14 01:34:52.563215459 +0000
+++ ./tokens/css/variables.css	2024-08-14 01:34:11.474926551 +0000
@@ -1,6 +1,6 @@
 /**
  * Do not edit directly
- * Generated on Tue Aug 13 2024 21:21:52 GMT+0000 (Coordinated Universal Time)
+ * Generated on Wed Aug 14 2024 01:34:11 GMT+0000 (Coordinated Universal Time)
  */
 
 :root {

src/components/buttonMenu/buttonMenu.svelte

github-actions · 2024-08-14T21:31:53Z

👋 Thanks for Submitting! This PR is available for preview at the link below.

✅ PR tip preview: https://776.pr.nala.bravesoftware.com/
✅ Commit preview: https://776.pr.nala.bravesoftware.com/commit-1bbc7240ecaa042cd30062734a794eb1d92d42a3/

- ./tokens/css/variables-android.old.css: 7424 bytes
+ ./tokens/css/variables-android.css: 7424 bytes
---
- ./tokens/css/variables-browser.old.css: 6670 bytes
+ ./tokens/css/variables-browser.css: 6670 bytes
---
- ./tokens/css/variables-ios.old.css: 7067 bytes
+ ./tokens/css/variables-ios.css: 7067 bytes
---
- ./tokens/css/variables-marketing.old.css: 13561 bytes
+ ./tokens/css/variables-marketing.css: 13561 bytes
---
- ./tokens/css/variables-news.old.css: 526 bytes
+ ./tokens/css/variables-news.css: 526 bytes
---
- ./tokens/css/variables-newtab.old.css: 1941 bytes
+ ./tokens/css/variables-newtab.css: 1941 bytes
---
- ./tokens/css/variables-search.old.css: 2419 bytes
+ ./tokens/css/variables-search.css: 2419 bytes
---
- ./tokens/css/variables-web3.old.css: 833 bytes
+ ./tokens/css/variables-web3.css: 833 bytes
---
- ./tokens/css/variables.old.css: 111822 bytes
+ ./tokens/css/variables.css: 111822 bytes

Variables Diff: variables-android.diff

--- ./tokens/css/variables-android.old.css	2024-08-14 21:30:23.826375349 +0000
+++ ./tokens/css/variables-android.css	2024-08-14 21:29:46.062111621 +0000
@@ -1,6 +1,6 @@
 /**
  * Do not edit directly
- * Generated on Wed Aug 14 2024 05:18:29 GMT+0000 (Coordinated Universal Time)
+ * Generated on Wed Aug 14 2024 21:29:46 GMT+0000 (Coordinated Universal Time)
  */
 
 :root {

Variables Diff: variables-browser.diff

--- ./tokens/css/variables-browser.old.css	2024-08-14 21:30:24.206377974 +0000
+++ ./tokens/css/variables-browser.css	2024-08-14 21:29:46.046111509 +0000
@@ -1,6 +1,6 @@
 /**
  * Do not edit directly
- * Generated on Wed Aug 14 2024 05:18:29 GMT+0000 (Coordinated Universal Time)
+ * Generated on Wed Aug 14 2024 21:29:46 GMT+0000 (Coordinated Universal Time)
  */
 
 :root {

Variables Diff: variables-ios.diff

--- ./tokens/css/variables-ios.old.css	2024-08-14 21:30:24.562380430 +0000
+++ ./tokens/css/variables-ios.css	2024-08-14 21:29:46.078111733 +0000
@@ -1,6 +1,6 @@
 /**
  * Do not edit directly
- * Generated on Wed Aug 14 2024 05:18:29 GMT+0000 (Coordinated Universal Time)
+ * Generated on Wed Aug 14 2024 21:29:46 GMT+0000 (Coordinated Universal Time)
  */
 
 :root {

Variables Diff: variables-marketing.diff

--- ./tokens/css/variables-marketing.old.css	2024-08-14 21:30:24.742381668 +0000
+++ ./tokens/css/variables-marketing.css	2024-08-14 21:29:46.102111900 +0000
@@ -1,6 +1,6 @@
 /**
  * Do not edit directly
- * Generated on Wed Aug 14 2024 05:18:29 GMT+0000 (Coordinated Universal Time)
+ * Generated on Wed Aug 14 2024 21:29:46 GMT+0000 (Coordinated Universal Time)
  */
 
 :root {

Variables Diff: variables-news.diff

--- ./tokens/css/variables-news.old.css	2024-08-14 21:30:25.138384395 +0000
+++ ./tokens/css/variables-news.css	2024-08-14 21:29:46.126112069 +0000
@@ -1,6 +1,6 @@
 /**
  * Do not edit directly
- * Generated on Wed Aug 14 2024 05:18:29 GMT+0000 (Coordinated Universal Time)
+ * Generated on Wed Aug 14 2024 21:29:46 GMT+0000 (Coordinated Universal Time)
  */
 
 :root {

Variables Diff: variables-newtab.diff

--- ./tokens/css/variables-newtab.old.css	2024-08-14 21:30:25.570387369 +0000
+++ ./tokens/css/variables-newtab.css	2024-08-14 21:29:46.138112153 +0000
@@ -1,6 +1,6 @@
 /**
  * Do not edit directly
- * Generated on Wed Aug 14 2024 05:18:29 GMT+0000 (Coordinated Universal Time)
+ * Generated on Wed Aug 14 2024 21:29:46 GMT+0000 (Coordinated Universal Time)
  */
 
 :root {

Variables Diff: variables-search.diff

--- ./tokens/css/variables-search.old.css	2024-08-14 21:30:25.998390322 +0000
+++ ./tokens/css/variables-search.css	2024-08-14 21:29:46.122112041 +0000
@@ -1,6 +1,6 @@
 /**
  * Do not edit directly
- * Generated on Wed Aug 14 2024 05:18:29 GMT+0000 (Coordinated Universal Time)
+ * Generated on Wed Aug 14 2024 21:29:46 GMT+0000 (Coordinated Universal Time)
  */
 
 :root {

Variables Diff: variables-web3.diff

--- ./tokens/css/variables-web3.old.css	2024-08-14 21:30:26.370392886 +0000
+++ ./tokens/css/variables-web3.css	2024-08-14 21:29:46.142112180 +0000
@@ -1,6 +1,6 @@
 /**
  * Do not edit directly
- * Generated on Wed Aug 14 2024 05:18:29 GMT+0000 (Coordinated Universal Time)
+ * Generated on Wed Aug 14 2024 21:29:46 GMT+0000 (Coordinated Universal Time)
  */
 
 @media (prefers-color-scheme: light) {

Variables Diff: variables.diff

--- ./tokens/css/variables.old.css	2024-08-14 21:30:27.066397677 +0000
+++ ./tokens/css/variables.css	2024-08-14 21:29:45.906110529 +0000
@@ -1,6 +1,6 @@
 /**
  * Do not edit directly
- * Generated on Wed Aug 14 2024 05:18:29 GMT+0000 (Coordinated Universal Time)
+ * Generated on Wed Aug 14 2024 21:29:45 GMT+0000 (Coordinated Universal Time)
  */
 
 :root {

AlanBreck · 2024-08-16T14:47:09Z

Since this change would be breaking, what's the migration path for existing consumers?

src/components/buttonMenu/buttonMenu.stories.svelte

need him to take another look

github-actions · 2024-09-16T09:30:44Z

👋 Thanks for Submitting! This PR is available for preview at the link below.

✅ PR tip preview: https://776.pr.nala.bravesoftware.com/
✅ Commit preview: https://776.pr.nala.bravesoftware.com/commit-1a50ff272fecce33b6218f8204eaad0cfdb3c2b5/

- ./tokens/css/variables-android.old.css: 7424 bytes
+ ./tokens/css/variables-android.css: 7424 bytes
---
- ./tokens/css/variables-browser.old.css: 6874 bytes
+ ./tokens/css/variables-browser.css: 6874 bytes
---
- ./tokens/css/variables-ios.old.css: 7067 bytes
+ ./tokens/css/variables-ios.css: 7067 bytes
---
- ./tokens/css/variables-marketing.old.css: 13561 bytes
+ ./tokens/css/variables-marketing.css: 13561 bytes
---
- ./tokens/css/variables-news.old.css: 526 bytes
+ ./tokens/css/variables-news.css: 526 bytes
---
- ./tokens/css/variables-newtab.old.css: 1941 bytes
+ ./tokens/css/variables-newtab.css: 1941 bytes
---
- ./tokens/css/variables-search.old.css: 2419 bytes
+ ./tokens/css/variables-search.css: 2419 bytes
---
- ./tokens/css/variables-web3.old.css: 905 bytes
+ ./tokens/css/variables-web3.css: 905 bytes
---
- ./tokens/css/variables.old.css: 114834 bytes
+ ./tokens/css/variables.css: 114834 bytes

Variables Diff: variables-android.diff

--- ./tokens/css/variables-android.old.css	2024-09-16 09:29:05.110946796 +0000
+++ ./tokens/css/variables-android.css	2024-09-16 09:28:27.090873044 +0000
@@ -1,6 +1,6 @@
 /**
  * Do not edit directly
- * Generated on Fri Sep 13 2024 16:35:10 GMT+0000 (Coordinated Universal Time)
+ * Generated on Mon Sep 16 2024 09:28:27 GMT+0000 (Coordinated Universal Time)
  */
 
 :root {

Variables Diff: variables-browser.diff

--- ./tokens/css/variables-browser.old.css	2024-09-16 09:29:05.394947395 +0000
+++ ./tokens/css/variables-browser.css	2024-09-16 09:28:27.074872999 +0000
@@ -1,6 +1,6 @@
 /**
  * Do not edit directly
- * Generated on Fri Sep 13 2024 16:35:10 GMT+0000 (Coordinated Universal Time)
+ * Generated on Mon Sep 16 2024 09:28:27 GMT+0000 (Coordinated Universal Time)
  */
 
 :root {

Variables Diff: variables-ios.diff

--- ./tokens/css/variables-ios.old.css	2024-09-16 09:29:05.622947881 +0000
+++ ./tokens/css/variables-ios.css	2024-09-16 09:28:27.106873088 +0000
@@ -1,6 +1,6 @@
 /**
  * Do not edit directly
- * Generated on Fri Sep 13 2024 16:35:10 GMT+0000 (Coordinated Universal Time)
+ * Generated on Mon Sep 16 2024 09:28:27 GMT+0000 (Coordinated Universal Time)
  */
 
 :root {

Variables Diff: variables-marketing.diff

--- ./tokens/css/variables-marketing.old.css	2024-09-16 09:29:05.862948385 +0000
+++ ./tokens/css/variables-marketing.css	2024-09-16 09:28:27.130873157 +0000
@@ -1,6 +1,6 @@
 /**
  * Do not edit directly
- * Generated on Fri Sep 13 2024 16:35:10 GMT+0000 (Coordinated Universal Time)
+ * Generated on Mon Sep 16 2024 09:28:27 GMT+0000 (Coordinated Universal Time)
  */
 
 :root {

Variables Diff: variables-news.diff

--- ./tokens/css/variables-news.old.css	2024-09-16 09:29:06.142948974 +0000
+++ ./tokens/css/variables-news.css	2024-09-16 09:28:27.154873225 +0000
@@ -1,6 +1,6 @@
 /**
  * Do not edit directly
- * Generated on Fri Sep 13 2024 16:35:10 GMT+0000 (Coordinated Universal Time)
+ * Generated on Mon Sep 16 2024 09:28:27 GMT+0000 (Coordinated Universal Time)
  */
 
 :root {

Variables Diff: variables-newtab.diff

--- ./tokens/css/variables-newtab.old.css	2024-09-16 09:29:06.358949430 +0000
+++ ./tokens/css/variables-newtab.css	2024-09-16 09:28:27.162873247 +0000
@@ -1,6 +1,6 @@
 /**
  * Do not edit directly
- * Generated on Fri Sep 13 2024 16:35:10 GMT+0000 (Coordinated Universal Time)
+ * Generated on Mon Sep 16 2024 09:28:27 GMT+0000 (Coordinated Universal Time)
  */
 
 :root {

Variables Diff: variables-search.diff

--- ./tokens/css/variables-search.old.css	2024-09-16 09:29:06.598949939 +0000
+++ ./tokens/css/variables-search.css	2024-09-16 09:28:27.150873213 +0000
@@ -1,6 +1,6 @@
 /**
  * Do not edit directly
- * Generated on Fri Sep 13 2024 16:35:10 GMT+0000 (Coordinated Universal Time)
+ * Generated on Mon Sep 16 2024 09:28:27 GMT+0000 (Coordinated Universal Time)
  */
 
 :root {

Variables Diff: variables-web3.diff

--- ./tokens/css/variables-web3.old.css	2024-09-16 09:29:06.814950393 +0000
+++ ./tokens/css/variables-web3.css	2024-09-16 09:28:27.170873269 +0000
@@ -1,6 +1,6 @@
 /**
  * Do not edit directly
- * Generated on Fri Sep 13 2024 16:35:10 GMT+0000 (Coordinated Universal Time)
+ * Generated on Mon Sep 16 2024 09:28:27 GMT+0000 (Coordinated Universal Time)
  */
 
 @media (prefers-color-scheme: light) {

Variables Diff: variables.diff

--- ./tokens/css/variables.old.css	2024-09-16 09:29:07.106951011 +0000
+++ ./tokens/css/variables.css	2024-09-16 09:28:26.950872649 +0000
@@ -1,6 +1,6 @@
 /**
  * Do not edit directly
- * Generated on Fri Sep 13 2024 16:35:10 GMT+0000 (Coordinated Universal Time)
+ * Generated on Mon Sep 16 2024 09:28:26 GMT+0000 (Coordinated Universal Time)
  */
 
 :root {

fallaciousreasoning added 2 commits August 13, 2024 09:10

[ButtonMenu]: Fix user provided width

e8b668f

[ButtonMenu]: Fix close handler

5af67cb

fallaciousreasoning requested a review from josheleonard August 12, 2024 21:15

fallaciousreasoning requested review from AlanBreck and petemill as code owners August 12, 2024 21:15

nullhook reviewed Aug 13, 2024

View reviewed changes

fallaciousreasoning changed the title ~~[ButtonMenu]: Fix min-width variable and close via click outside~~ [ButtonMenu]: **BREAKING** Fix min-width variable and close via click outside Aug 13, 2024

josheleonard reviewed Aug 13, 2024

View reviewed changes

src/components/buttonMenu/buttonMenu.svelte Show resolved Hide resolved

josheleonard reviewed Aug 14, 2024

View reviewed changes

src/components/buttonMenu/buttonMenu.svelte Outdated Show resolved Hide resolved

Changes for PR

1bbc724

fallaciousreasoning force-pushed the button-menu-fixes branch from c849157 to 1bbc724 Compare August 14, 2024 21:29

AlanBreck previously requested changes Aug 16, 2024

View reviewed changes

src/components/buttonMenu/buttonMenu.stories.svelte Show resolved Hide resolved

Changes for PR

1a50ff2

fallaciousreasoning requested a review from AlanBreck September 16, 2024 09:28

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

[ButtonMenu]: BREAKING Fix `min-width` variable and close via click outside #776

[ButtonMenu]: BREAKING Fix `min-width` variable and close via click outside #776

Uh oh!

fallaciousreasoning commented Aug 12, 2024

Uh oh!

github-actions bot commented Aug 12, 2024

Uh oh!

nullhook Aug 13, 2024

Uh oh!

fallaciousreasoning Aug 13, 2024

Uh oh!

nullhook Aug 13, 2024

Uh oh!

fallaciousreasoning Aug 13, 2024

Uh oh!

Uh oh!

github-actions bot commented Aug 14, 2024

Uh oh!

Uh oh!

github-actions bot commented Aug 14, 2024

Uh oh!

AlanBreck commented Aug 16, 2024

Uh oh!

Uh oh!

github-actions bot commented Sep 16, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

[ButtonMenu]: **BREAKING** Fix min-width variable and close via click outside #776

Are you sure you want to change the base?

[ButtonMenu]: **BREAKING** Fix min-width variable and close via click outside #776

Uh oh!

Conversation

fallaciousreasoning commented Aug 12, 2024

Uh oh!

github-actions bot commented Aug 12, 2024

Uh oh!

nullhook Aug 13, 2024

Choose a reason for hiding this comment

Uh oh!

fallaciousreasoning Aug 13, 2024

Choose a reason for hiding this comment

Uh oh!

nullhook Aug 13, 2024

Choose a reason for hiding this comment

Uh oh!

fallaciousreasoning Aug 13, 2024

Choose a reason for hiding this comment

Uh oh!

Uh oh!

github-actions bot commented Aug 14, 2024

Uh oh!

Uh oh!

github-actions bot commented Aug 14, 2024

Uh oh!

AlanBreck commented Aug 16, 2024

Uh oh!

Uh oh!

github-actions bot commented Sep 16, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

[ButtonMenu]: BREAKING Fix `min-width` variable and close via click outside #776

[ButtonMenu]: BREAKING Fix `min-width` variable and close via click outside #776