Use SSP pubkey to identify Lightning vs HTLC payments #443
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
@danielgranhao what is the advantage of this method given the fact the user request is populated automatically by the SO? |
Collaborator
Author
Increased resiliency. If, for any reason, the SSP fails to provide the lightning user request, we end up with empty |
danielgranhao
force-pushed
the
daniel-improve-ln-vs-htlc-logic
branch
from
95aad87 to
f5f9980
Compare
Collaborator
|
This also fixes an issue where the payment details for a Spark payment are none if there is no invoice or htlc details |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This proposes an improvement over #440. It drops the reliance on the SSP in order to distinguish Lightning from HTLC payments.
Instead, we infer if a payment is Lightning if the transfer was sent to or received from the SSP. This only works while there is a single static SSP, and we'll need to find another solution when that stops being the case.