Skip to content

Conversation

McAllaster
Copy link

This pull request updates nextra to version 3 (following the migration guide), and updates its dependencies.

Nextra had an odd issue with font rendering using the ss06 font feature settings on fonts which support it, causing issues with capital letters (see image below). It has since been resolved.

font rendering example

I am sure there are other changes that v3 introduced, but I did not notice any regressions in the documentation.

Note that v4 of nextra is available, but being fairly unfamiliar with it, I opted to only upgrade a single major version.

"build": "next build && next export"
"dev": "next dev",
"build": "next build",
"start": "next start"
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just noticed that next start doesn't work with the output: 'export' configuration. This line can probably be removed.

"scripts": {
"start": "next dev",
"build": "next build && next export"
"dev": "next dev",
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The README.md for docs has instructions to run the dev command, so I moved next dev to use that command instead of start.

Copy link
Collaborator

@charmander charmander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

with the caveat that I haven’t reviewed the 470 dependencies used in 20 static pages of documentation, and hope anyone attempting to render the docs is doing so in a suitable sandbox.

Thank you for fixing this longstanding bug!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants