Skip to content

Test updating to java 21 #1931

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 3 commits into
base: master
Choose a base branch
from
Draft

Test updating to java 21 #1931

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
d76c5cd
Updating to require java 21
lbergelson Dec 19, 2023
184883b
fixup
lbergelson Dec 19, 2023
3167fac
remove newly disallowed ;
lbergelson Dec 19, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/cloud_tests.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ jobs:
needs: check-secrets
strategy:
matrix:
java: [ 17 ]
java: [ 21 ]
run_barclay_tests: [true, false]
experimental: [ false ]
fail-fast: false
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/tests.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ jobs:
runs-on: ubuntu-latest
strategy:
matrix:
java: [ 17 ]
java: [ 21 ]
experimental: [false]
run_barclay_tests: [true, false]
fail-fast: false
Expand Down
4 changes: 2 additions & 2 deletions build.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,7 +70,7 @@ dependencies {
implementation 'org.apache.commons:commons-math3:3.6.1'
implementation 'org.apache.commons:commons-collections4:4.4'
implementation 'com.github.samtools:htsjdk:' + htsjdkVersion
implementation 'org.broadinstitute:barclay:5.0.0'
implementation 'org.broadinstitute:barclay:4.1.0-9-g264e876-SNAPSHOT'
implementation 'org.apache.logging.log4j:log4j-api:2.20.0'
implementation 'org.apache.logging.log4j:log4j-core:2.20.0'
implementation 'org.openjdk.nashorn:nashorn-core:15.4'
Expand All @@ -92,7 +92,7 @@ configurations.configureEach {

java {
toolchain {
languageVersion = JavaLanguageVersion.of(17)
languageVersion = JavaLanguageVersion.of(21)
}
withJavadocJar()
withSourcesJar()
Expand Down
1 change: 0 additions & 1 deletion src/test/java/picard/util/GraphUtilsTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
package picard.util;

;
import org.testng.annotations.Test;

import java.util.Arrays;
Expand Down
1 change: 0 additions & 1 deletion testdata/picard/util/BedToIntervalListTest/simple.bed
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,2 @@

chr1 100 2000
chr1 3000 4000