-
Notifications
You must be signed in to change notification settings - Fork 0
Feat portfolio cards #261
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Feat portfolio cards #261
Conversation
…ages using slug in yaml
|
Note: This comment gets updated with every commit
7c1071a071f6c5d796ec12cea90cca3214f1f24b |
|
🚀 Your preview is ready! Preview URL: https://ccv-website-next--preview-261-h9e5wz1i.web.app This preview will be automatically updated with each new commit to this PR. |
…s bigger and fixed image size, added dept to card if exists, changed dummy data to have project consulting project types
…roject or workshop
… categories. badges in the portfolio page should ;always be one of these 8 categories
…sed on card content
… than direct imports into the component
…se more keys are added to projects yaml
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR implements a portfolio section featuring cards and detail pages for projects and workshops, introducing a comprehensive portfolio system with navigation integration.
- Added portfolio data types and content structure for projects and workshops
- Created portfolio card components for both overview and detail views
- Integrated portfolio navigation into the main navbar
Reviewed Changes
Copilot reviewed 17 out of 17 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| lib/storage-types.ts | Modified ServiceLink interface to use display_text instead of category |
| lib/portfolio-types.ts | Added TypeScript interfaces for portfolio data structure |
| content/portfolio/workshops.yaml | Added workshop portfolio data with metadata and links |
| content/portfolio/projects.yaml | Added project portfolio data with comprehensive project information |
| components/ui/Badge.tsx | Updated badge padding from py-0.5 to py-1 for better visual appearance |
| components/card/StorageServiceCard.tsx | Removed redundant styling from badge className |
| components/card/ProjectOverviewCard.tsx | Created overview card component for portfolio listings |
| components/card/ProjectDetailCard.tsx | Created detailed card component for individual portfolio pages |
| components/TechnicalExpertiseHeader.tsx | Added header component with icons for technical expertise types |
| components/Navbar.tsx | Added portfolio navigation links for projects and workshops |
| components/FeaturedCarousel.tsx | Removed redundant badge styling |
| components/ContentSection.tsx | Made title optional and added header boolean prop |
| app/portfolio/workshops/page.tsx | Created workshops portfolio listing page |
| app/portfolio/workshops/[slug]/page.tsx | Created dynamic workshop detail pages |
| app/portfolio/projects/page.tsx | Created projects portfolio listing page |
| app/portfolio/projects/[slug]/page.tsx | Created dynamic project detail pages |
| app/page.tsx | Updated home page to use new ContentSection API |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
…ct detail page - icon implies external link so might not be ideal
Co-authored-by: Copilot <[email protected]>
Co-authored-by: Copilot <[email protected]>
|
@ashleysyg let's close this pr, i don't think we're moving forward with this |
This PR creates a portfolio card and detail page. I added toy data for now.